Skip to content

misc: rtsx: Clean up Realtek card reader driver

Bjorn Helgaas linux-pci lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6misc: rtsx: Remove unused pcr_opsdrivers/misc/cardreader/rtsx_pcr.c include/linux/rtsx_pci.h+3 -160 replies
2/6misc: rtsx: Removed unused dev_aspm_modedrivers/misc/cardreader/rts5249.c drivers/misc/cardreader/rts5260.c drivers/misc/cardreader/rts5261.c +2 more+18 -830 replies
3/6misc: rtsx: Use ASPM_MASK_NEG instead of hard-coded valuedrivers/misc/cardreader/rtsx_pcr.c+2 -20 replies
4/6misc: rtsx: Use pcie_capability_clear_and_set_word() for PCI_EXP_LNKCTLdrivers/misc/cardreader/rts5249.c drivers/misc/cardreader/rts5260.c drivers/misc/cardreader/rts5261.c +3 more+14 -390 replies
5/6misc: rtsx: Simplify rtsx_comm_set_aspm()drivers/misc/cardreader/rtsx_pcr.c+3 -100 replies
6/6misc: rtsx: Remove unnecessary rts5249_set_aspm(), rts5260_set_aspm()drivers/misc/cardreader/rts5249.c drivers/misc/cardreader/rts5260.c+0 -280 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] misc: rtsx: Clean up Realtek card reader driver

From: Bjorn Helgaas <[email protected]>

These are minor cleanups of the Realtek card reader driver. They shouldn't fix or break anything by themselves; they're just to make it slightly more readable and maintainable.

Bjorn Helgaas (6):
misc: rtsx: Remove unused pcr_ops
misc: rtsx: Removed unused dev_aspm_mode
misc: rtsx: Use ASPM_MASK_NEG instead of hard-coded value
misc: rtsx: Use pcie_capability_clear_and_set_word() for
PCI_EXP_LNKCTL
misc: rtsx: Simplify rtsx_comm_set_aspm()
misc: rtsx: Remove unnecessary rts5249_set_aspm(), rts5260_set_aspm()

 drivers/misc/cardreader/rts5249.c  | 29 --------------------
 drivers/misc/cardreader/rts5260.c  | 26 ------------------
 drivers/misc/cardreader/rts5261.c  | 38 +++-----------------------
 drivers/misc/cardreader/rtsx_pcr.c | 43 ++++++------------------------
 drivers/misc/cardreader/rtsx_pcr.h |  1 -
 include/linux/rtsx_pci.h           | 25 -----------------
 6 files changed, 12 insertions(+), 150 deletions(-)

base-commit: 8f3d9f354286745c751374f5f1fcafee6b3f3136

Signature · 1 line
2.25.1