more l2tp locking and ordering fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest27 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/27 | l2tp: lock socket before checking flags in connect()include/ net/ net/ +1 more | +28 | 0 replies | |
| 2/27 | l2tp: fix racy socket lookup in l2tp_ip and l2tp_ip6 bind()net/ net/ | +32 | 0 replies | |
| 3/27 | l2tp: hold session while sending creation notificationsnet/ | +4 | 0 replies | |
| 4/27 | l2tp: take a reference on sessions used in genetlink handlersnet/ net/ net/ | +35 | 0 replies | |
| 5/27 | l2tp: don't use l2tp_tunnel_find() in l2tp_ip and l2tp_ip6net/ net/ | +16 | 0 replies | |
| 6/27 | net: l2tp: export debug flags to UAPIinclude/ net/ | +16 | 0 replies | |
| 7/27 | net: l2tp: deprecate PPPOL2TP_MSG_* in favour of L2TP_MSG_*Documentation/ include/ | +10 | 1 reply | |
| 8/27 | net: l2tp: ppp: change PPPOL2TP_MSG_* => L2TP_MSG_*net/ | +27 | 0 replies | |
| 9/27 | New kernel function to get IP overhead on a socket.include/ net/ | +49 | 0 replies | |
| 10/27 | L2TP:Adjust intf MTU, add underlay L3, L2 hdrs.net/ | +51 | 0 replies | |
| 11/27 | l2tp: remove useless duplicate session detection in l2tp_netlinknet/ | +0 | 0 replies | |
| 12/27 | l2tp: remove l2tp_session_find()net/ net/ | +1 | 0 replies | |
| 13/27 | l2tp: define parameters of l2tp_session_get*() as "const"net/ net/ | +7 | 0 replies | |
| 14/27 | l2tp: define parameters of l2tp_tunnel_find*() as "const"net/ net/ | +4 | 0 replies | |
| 15/27 | l2tp: initialise session's refcount before making it reachablenet/ | +2 | 0 replies | |
| 16/27 | l2tp: hold tunnel while looking up sessions in l2tp_netlinknet/ net/ net/ | +38 | 0 replies | |
| 17/27 | l2tp: hold tunnel while processing genl delete commandnet/ | +4 | 0 replies | |
| 18/27 | l2tp: hold tunnel while handling genl tunnel updatesnet/ | +4 | 0 replies | |
| 19/27 | l2tp: hold tunnel while handling genl TUNNEL_GET commandsnet/ | +15 | 0 replies | |
| 20/27 | l2tp: hold tunnel used while creating sessions with netlinknet/ | +12 | 0 replies | |
| 21/27 | l2tp: prevent creation of sessions on terminated tunnelsnet/ net/ | +32 | 0 replies | |
| 22/27 | l2tp: pass tunnel pointer to ->session_create()net/ net/ net/ +1 more | +17 | 0 replies | |
| 23/27 | l2tp: fix l2tp_eth module loadingnet/ | +2 | 0 replies | |
| 24/27 | l2tp: don't register sessions in l2tp_session_create()net/ net/ net/ +1 more | +36 | 0 replies | |
| 25/27 | l2tp: initialise l2tp_eth sessions before registering themnet/ | +76 | 0 replies | |
| 26/27 | l2tp: protect sock pointer of struct pppol2tp_session with RCUnet/ | +101 | 0 replies | |
| 27/27 | l2tp: initialise PPP sessions before registering themnet/ | +38 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/27] more l2tp locking and ordering fixes
Hi Greg.
This is for 4.4.
This is a follow-up to "l2tp locking and ordering fixes" for 4.9.
Compared with that series, this pulls in 5 more patches (the first 5 Guillaume Nault ones below) containing more of the same as well as making later changes apply more cleanly.
As before, every commit compiles with make allmodconfig, but I have no hardware to test this with.
9dd79945b0f8 (use IS_ENABLED) would have made one patch or so cleaner but I didn't add it.
There are also bunch of fixes that aren't l2tp locking or ordering fixes and I didn't add them either. For the record...
Between 4.4 and 4.9:
018f82585823 net: l2tp: fix reversed udp6 checksum flags 56cff471d0c6 l2tp: Fix the connect status check in pppol2tp_getname 286c72deabaa udp: must lock the socket in udp_disconnect() df90e6886146 l2tp: fix lookup for sockets not bound to a device in l2tp_ip 31e2f21fb35b l2tp: fix address test in __l2tp_ip6_bind_lookup()
Between 4.9 and 4.9.latest:
000224c1106c l2tp: consider '::' as wildcard address in l2tp_ip6 socket lookup d2d74d0e58b2 l2tp: take remote address into account in l2tp_ip and l2tp_ip6 socket lookups 65b05d03a578 l2tp: remove configurable payload offsetb437ed583592 l2tp: Fix possible NULL pointer dereference
Regards,
Giuliano.
Asbjørn Sloth Tønnesen (3):
net: l2tp: export debug flags to UAPI
net: l2tp: deprecate PPPOL2TP_MSG_* in favour of L2TP_MSG_*
net: l2tp: ppp: change PPPOL2TP_MSG_* => L2TP_MSG_*
Guillaume Nault (22):
l2tp: lock socket before checking flags in connect()
l2tp: fix racy socket lookup in l2tp_ip and l2tp_ip6 bind()
l2tp: hold session while sending creation notifications
l2tp: take a reference on sessions used in genetlink handlers
l2tp: don't use l2tp_tunnel_find() in l2tp_ip and l2tp_ip6
l2tp: remove useless duplicate session detection in l2tp_netlink
l2tp: remove l2tp_session_find()
l2tp: define parameters of l2tp_session_get*() as "const"
l2tp: define parameters of l2tp_tunnel_find*() as "const"
l2tp: initialise session's refcount before making it reachable
l2tp: hold tunnel while looking up sessions in l2tp_netlink
l2tp: hold tunnel while processing genl delete command
l2tp: hold tunnel while handling genl tunnel updates
l2tp: hold tunnel while handling genl TUNNEL_GET commands
l2tp: hold tunnel used while creating sessions with netlink
l2tp: prevent creation of sessions on terminated tunnels
l2tp: pass tunnel pointer to ->session_create()
l2tp: fix l2tp_eth module loading
l2tp: don't register sessions in l2tp_session_create()
l2tp: initialise l2tp_eth sessions before registering them
l2tp: protect sock pointer of struct pppol2tp_session with RCU
l2tp: initialise PPP sessions before registering them
R. Parameswaran (2):
New kernel function to get IP overhead on a socket. L2TP:Adjust intf MTU, add underlay L3, L2 hdrs.
Documentation/networking/l2tp.txt | 8 +- include/linux/net.h | 3 + include/net/ipv6.h | 2 + include/uapi/linux/if_pppol2tp.h | 13 +- include/uapi/linux/l2tp.h | 17 +- net/ipv6/datagram.c | 4 +- net/l2tp/l2tp_core.c | 181 ++++++----------- net/l2tp/l2tp_core.h | 47 +++-- net/l2tp/l2tp_eth.c | 214 +++++++++++++-------- net/l2tp/l2tp_ip.c | 68 ++++--- net/l2tp/l2tp_ip6.c | 82 ++++---- net/l2tp/l2tp_netlink.c | 124 +++++++----- net/l2tp/l2tp_ppp.c | 309 ++++++++++++++++++------------ net/socket.c | 46 +++++ 14 files changed, 629 insertions(+), 489 deletions(-)
Signature · 1 line
2.27.0.rc0.183.gde8f92d652-goog