coroutines: generate wrapper code
Status from this message: Thanks, applied to my block tree with the encoding='utf-8' and
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest7 patches 6 repliesApplied
- v87 patches 26 repliesSuperseded
- v77 patches 5 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v6 | 7 patches | 4 replies | Superseded | |
| v5 | 7 patches | 3 replies | Superseded | |
| v4 | 5 patches | 9 replies | Superseded | |
| v3 | 3 patches | 3 replies | Superseded |
Patches in v9 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | block: return error-code from bdrv_invalidate_cacheblock.c include/ | +19 | 0 replies | |
| 2/7 | block/io: refactor coroutine wrappersblock/ | +32 | 0 replies | |
| 3/7 | block: declare some coroutine functions in block/coroutines.hblock.c block/ block/ | +88 | 0 replies | |
| 4/7 | scripts: add block-coroutine-wrapper.pyblock/ block/ docs/ +3 more | +310 | 2 replies | |
| 5/7 | block: generate coroutine-wrapper codeblock.c block/ block/ +1 more | +13 | 0 replies | |
| 6/7 | block: drop bdrv_prwvblock/ block/ include/ +1 more | +15 | 0 replies | |
| 7/7 | block/io: refactor save/load vmstateblock/ block/ include/ | +43 | 0 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Eric Blake | Philippe Mathieu-Daudé | Stefan Hajnoczi |
|---|---|---|---|
| Series | R-b | ||
| 1/7 | R-b | R-b | R-b |
| 2/7 | R-b | R-b | R-b |
| 3/7 | R-b | R-b | R-b |
| 4/7 | R-b | ||
| 5/7 | R-b | R-b | |
| 6/7 | R-b | R-b | R-b |
| 7/7 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v9 0/7] coroutines: generate wrapper code
Hi all!
The aim of the series is to reduce code-duplication and writing parameters structure-packing by hand around coroutine function wrappers.
Benefits:
- no code duplication
- less indirection
v9: Thanks to Eric, I used commit message tweaks and rebase-conflict solving from his git. 01: add Philippe's, Stefan's r-bs
02: - add Philippe's, Stefan's r-bs
- commit message tweaks stolen from Eric's git :)
03: add Philippe's, Stefan's r-bs
04: - wording/grammar by Eric (partly, stolen from repo)
- ref new file in docs/devel/index.rst
- use 644 rights and recommended header for python script
- call gen_header() once
- rename gen_wrappers_file to gen_wrappers
05: add Stefan's r-b
06: add Philippe's, Stefan's r-bs
07: Stefan's r-b
Vladimir Sementsov-Ogievskiy (7):
block: return error-code from bdrv_invalidate_cache block/io: refactor coroutine wrappers
block: declare some coroutine functions in block/coroutines.h
scripts: add block-coroutine-wrapper.py
block: generate coroutine-wrapper code
block: drop bdrv_prwv
block/io: refactor save/load vmstate
docs/devel/block-coroutine-wrapper.rst | 54 ++++ docs/devel/index.rst | 1 + block/block-gen.h | 49 ++++ block/coroutines.h | 65 +++++ include/block/block.h | 34 ++- block.c | 97 +------ block/io.c | 337 ++++--------------------- tests/test-bdrv-drain.c | 2 +- block/meson.build | 8 + scripts/block-coroutine-wrapper.py | 188 ++++++++++++++ 10 files changed, 454 insertions(+), 381 deletions(-) create mode 100644 docs/devel/block-coroutine-wrapper.rst create mode 100644 block/block-gen.h create mode 100644 block/coroutines.h create mode 100644 scripts/block-coroutine-wrapper.py
Signature · 1 line
2.21.3