Skip to content

Fix issue with not starting nesting guests on my system

Maxim Levitsky kvm lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 0 repliesNew
  2. v12 patches 10 repliesApplied

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2KVM: VMX: enable X86_FEATURE_WAITPKG in KVM capabilitiesarch/x86/kvm/vmx/vmx.c+3 -00 replies
2/2KVM: x86: don't expose MSR_IA32_UMWAIT_CONTROL unconditionallyarch/x86/kvm/x86.c+4 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSean ChristophersonKrish Sadhukhan
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Fix issue with not starting nesting guests on my system

On my AMD machine I noticed that I can't start any nested guests, because nested KVM (everything from master git branches) complains that it can't find msr MSR_IA32_UMWAIT_CONTROL which my system doesn't support at all anyway.

I traced it to the recently added UMWAIT support to qemu and kvm. The kvm portion exposed the new MSR in KVM_GET_MSR_INDEX_LIST without checking that it the underlying feature is supported in CPUID. It happened to work when non nested because as a precation kvm, tries to read each MSR on host before adding it to that list, and when read gets a #GP it ignores it.

When running nested, the L1 hypervisor can be set to ignore unknown msr read/writes (I need this for some other guests), thus this safety check doesn't work anymore.

V2: * added a patch to setup correctly the X86_FEATURE_WAITPKG kvm capability
* dropped the cosmetic fix patch as it is now fixed in kvm/queue

V3: addressed the review feedback and possibly made the commit messages a bit better
Thanks!

Best regards,
Maxim Levitsky

Maxim Levitsky (2):
KVM: VMX: enable X86_FEATURE_WAITPKG in KVM capabilities
KVM: x86: don't expose MSR_IA32_UMWAIT_CONTROL unconditionally

 arch/x86/kvm/vmx/vmx.c | 3 +++
 arch/x86/kvm/x86.c     | 4 ++++
 2 files changed, 7 insertions(+)
Signature · 1 line
2.26.2