Skip to content

checkpatch.pl: Add features to help improve U-Boot code

Tom Rini u-boot 1 version New

Get series with b4
b4 am 20200524182335.GI26741@bill-the-cat

Versions newest first

  1. v1 Latest6 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6checkpatch.pl: Update to v5.7-rc6+0 -00 replies
2/6checkpatch.pl: Add a U-Boot option+0 -00 replies
3/6checkpatch.pl: Add a check for tests needed for uclasses+0 -00 replies
4/6checkpatch.pl: Warn if the flattree API is used+0 -00 replies
5/6checkpatch.pl: Request a test when a new command is added+0 -00 replies
6/6checkpatch.pl: Request if() instead #ifdef+0 -02 replies
6/6checkpatch.pl: Request if() instead #ifdef+0 -02 replies
6/6checkpatch.pl: Request if() instead #ifdef+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] checkpatch.pl: Add features to help improve U-Boot code
Quoted 19 lines · Simon Glass

U-Boot mostly follows linux for coding style, but it has some of its own features. These come up again and again in code review. We should try to reduce the load of reviewers.

This series adds a little U-Boot function to the checkpatch script and an option to enable it. Hopefully it is easy enough to maintain this as the script is updated, even if it is not accepted upstream.

Some initial checks are included as examples of what we can do.

Simon Glass (6):
checkpatch.pl: Update to v5.7-rc6
checkpatch.pl: Add a U-Boot option checkpatch.pl: Add a check for tests needed for uclasses checkpatch.pl: Warn if the flattree API is used checkpatch.pl: Request a test when a new command is added checkpatch.pl: Request if() instead #ifdef

Quoted 4 lines
 .checkpatch.conf      |   3 +
 doc/README.commands   |  50 +++++++++
 scripts/checkpatch.pl | 252 +++++++++++++++---------------------------
 3 files changed, 144 insertions(+), 161 deletions(-)

I'm not reviewing the changes as I am not a pearl person but I think this is a great idea and will help keep us from dropping our changes in the future too. I'll rebase my CONFIG_CMD_xxx check on top of your series before applying.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200524/98584393/attachment.sig>