Skip to content

Coverity fixes for vchan-socket-proxy

Jason Andryuk xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 4 repliesIn review
  2. v18 patches 5 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10vchan-socket-proxy: Ensure UNIX path NUL terminatedtools/libvchan/vchan-socket-proxy.c+14 -20 replies
2/10vchan-socket-proxy: Move perror() into listen_sockettools/libvchan/vchan-socket-proxy.c+6 -20 replies
3/10vchan-socket-proxy: Move perror() into connect_sockettools/libvchan/vchan-socket-proxy.c+5 -20 replies
4/10vchan-socket-proxy: Check xs_watch return valuetools/libvchan/vchan-socket-proxy.c+9 -20 replies
5/10vchan-socket-proxy: Unify main return valuetools/libvchan/vchan-socket-proxy.c+11 -40 replies
6/10vchan-socket-proxy: Use a struct to store statetools/libvchan/vchan-socket-proxy.c+30 -220 replies
7/10vchan-socket-proxy: Switch data_loop() to take statetools/libvchan/vchan-socket-proxy.c+33 -320 replies
8/10vchan-socket-proxy: Set closed FDs to -1tools/libvchan/vchan-socket-proxy.c+2 -00 replies
9/10vchan-socket-proxy: Cleanup resources on exittools/libvchan/vchan-socket-proxy.c+9 -00 replies
10/10vchan-socket-proxy: Handle closing shared input/output_fdtools/libvchan/vchan-socket-proxy.c+2 -00 replies

Reviews trailers per patch

None of the 10 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchWei LiuPaul Durrant
SeriesA-b Release-acked-by
1/10
2/10
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/10] Coverity fixes for vchan-socket-proxy

This series addresses some Coverity reports. To handle closing FDs, a state struct is introduced to track FDs closed in both main() and data_loop().

v2 changes "Ensure UNIX path NUL terminated" to avoid a warning with gcc-10. Also, "Move perror() into listen_socket" and "Move perror() into connect_socket" are new.

Jason Andryuk (10):
vchan-socket-proxy: Ensure UNIX path NUL terminated
vchan-socket-proxy: Move perror() into listen_socket
vchan-socket-proxy: Move perror() into connect_socket
vchan-socket-proxy: Check xs_watch return value
vchan-socket-proxy: Unify main return value
vchan-socket-proxy: Use a struct to store state
vchan-socket-proxy: Switch data_loop() to take state
vchan-socket-proxy: Set closed FDs to -1
vchan-socket-proxy: Cleanup resources on exit
vchan-socket-proxy: Handle closing shared input/output_fd

 tools/libvchan/vchan-socket-proxy.c | 183 ++++++++++++++++++----------
 1 file changed, 119 insertions(+), 64 deletions(-)
Signature · 1 line
2.25.1