Coverity fixes for vchan-socket-proxy
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest10 patches 4 repliesIn review
- v18 patches 5 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | vchan-socket-proxy: Ensure UNIX path NUL terminatedtools/ | +14 | 0 replies | |
| 2/10 | vchan-socket-proxy: Move perror() into listen_sockettools/ | +6 | 0 replies | |
| 3/10 | vchan-socket-proxy: Move perror() into connect_sockettools/ | +5 | 0 replies | |
| 4/10 | vchan-socket-proxy: Check xs_watch return valuetools/ | +9 | 0 replies | |
| 5/10 | vchan-socket-proxy: Unify main return valuetools/ | +11 | 0 replies | |
| 6/10 | vchan-socket-proxy: Use a struct to store statetools/ | +30 | 0 replies | |
| 7/10 | vchan-socket-proxy: Switch data_loop() to take statetools/ | +33 | 0 replies | |
| 8/10 | vchan-socket-proxy: Set closed FDs to -1tools/ | +2 | 0 replies | |
| 9/10 | vchan-socket-proxy: Cleanup resources on exittools/ | +9 | 0 replies | |
| 10/10 | vchan-socket-proxy: Handle closing shared input/output_fdtools/ | +2 | 0 replies |
Reviews trailers per patch
None of the 10 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Wei Liu | Paul Durrant |
|---|---|---|
| Series | A-b | Release-acked-by |
| 1/10 | ||
| 2/10 | ||
| 3/10 | ||
| 4/10 | ||
| 5/10 | ||
| 6/10 | ||
| 7/10 | ||
| 8/10 | ||
| 9/10 | ||
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/10] Coverity fixes for vchan-socket-proxy
This series addresses some Coverity reports. To handle closing FDs, a state struct is introduced to track FDs closed in both main() and data_loop().
v2 changes "Ensure UNIX path NUL terminated" to avoid a warning with gcc-10. Also, "Move perror() into listen_socket" and "Move perror() into connect_socket" are new.
Jason Andryuk (10):
vchan-socket-proxy: Ensure UNIX path NUL terminated
vchan-socket-proxy: Move perror() into listen_socket
vchan-socket-proxy: Move perror() into connect_socket
vchan-socket-proxy: Check xs_watch return value
vchan-socket-proxy: Unify main return value
vchan-socket-proxy: Use a struct to store state
vchan-socket-proxy: Switch data_loop() to take state
vchan-socket-proxy: Set closed FDs to -1
vchan-socket-proxy: Cleanup resources on exit
vchan-socket-proxy: Handle closing shared input/output_fd
tools/libvchan/vchan-socket-proxy.c | 183 ++++++++++++++++++---------- 1 file changed, 119 insertions(+), 64 deletions(-)
Signature · 1 line
2.25.1