Skip to content

gpio: generic regmap implementation

Michael Walle linux-gpio lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 4 repliesIn review
  2. v52 patches 4 repliesSuperseded
  3. v42 patches 7 repliesSuperseded

Changes in v6 from the cover letter

- add names property
- addressed Alex' remarks:
- moved header from i/l/gpio-regmap.h to i/l/gpio/regmap.h
- fixed kernel doc
- described rules how to use the register base offsets
- missing forward declarations
- style changes
- return -EOPNOTSUPP, in code path we should never reach
- added check to have input and output base regs if there is a direction register
- added MAINTAINERS patch

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3gpiolib: Introduce gpiochip_irqchip_add_domain()drivers/gpio/gpiolib.c include/linux/gpio/driver.h+23 -00 replies
2/3gpio: add a reusable generic gpio_chip using regmapdrivers/gpio/Kconfig drivers/gpio/Makefile drivers/gpio/gpio-regmap.c +1 more+440 -02 replies
3/3MAINTAINERS: Add gpio regmap sectionMAINTAINERS+6 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy ShevchenkoPierre-Louis Bossart
SeriesR-b
1/3
2/3T-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/3] gpio: generic regmap implementation

This series is a split off of the sl28cpld series:
https://lore.kernel.org/linux-gpio/[email protected]/

I wasn't sure if I should also include the gpiochip_irqchip_add_domain() patch here. So feel free to skip it. OTOH if you use interrupts with gpio-regmap it is quite handy.

For an actual user see the patch 11/16 ("gpio: add support for the sl28cpld GPIO controller") of the series above.

Changes since v5:
- add names property
- addressed Alex' remarks:
- moved header from i/l/gpio-regmap.h to i/l/gpio/regmap.h
- fixed kernel doc
- described rules how to use the register base offsets
- missing forward declarations
- style changes
- return -EOPNOTSUPP, in code path we should never reach
- added check to have input and output base regs if there is a direction register
- added MAINTAINERS patch

Changes since v4:
- add comment about can_sleep
- fix config->label typo
- add config->names property

Changes since v3:
- set reg_dat_base, that was actually broken
- fix typo
- fix swapped reg_in_dir/reg_out_dir documentation
- use "goto err" in error path in gpio_regmap_register()

Michael Walle (3):
gpiolib: Introduce gpiochip_irqchip_add_domain()
gpio: add a reusable generic gpio_chip using regmap
MAINTAINERS: Add gpio regmap section

 MAINTAINERS                 |   6 +
 drivers/gpio/Kconfig        |   4 +
 drivers/gpio/Makefile       |   1 +
 drivers/gpio/gpio-regmap.c  | 349 ++++++++++++++++++++++++++++++++++++
 drivers/gpio/gpiolib.c      |  20 +++
 include/linux/gpio/driver.h |   3 +
 include/linux/gpio/regmap.h |  86 +++++++++
 7 files changed, 469 insertions(+)
 create mode 100644 drivers/gpio/gpio-regmap.c
 create mode 100644 include/linux/gpio/regmap.h
Signature · 1 line
2.20.1