Skip to content

net_sched: reduce the number of qdisc resets

Cong Wang netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net_sched: use qdisc_reset() in qdisc_destroy()net/sched/sch_generic.c+3 -130 replies
2/5net_sched: add tracepoints for qdisc_reset() and qdisc_destroy()include/trace/events/qdisc.h net/sched/sch_generic.c+56 -01 reply
3/5net_sched: add a tracepoint for qdisc creationinclude/trace/events/qdisc.h net/sched/sch_api.c net/sched/sch_generic.c+29 -10 replies
4/5net_sched: avoid resetting active qdisc for multiple timesnet/sched/sch_generic.c+23 -140 replies
5/5net_sched: get rid of unnecessary dev_qdisc_reset()net/sched/sch_generic.c+0 -160 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchVáclav Zindulka
1/5
2/5
3/5
4/5T-b
5/5T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Patch net-next 0/5] net_sched: reduce the number of qdisc resets

This patchset aims to reduce the number of qdisc resets during qdisc tear down. Patch 1~3 are preparation for their following patches, especially patch 2 and patch 3 add a few tracepoints so that we can observe the whole lifetime of qdisc's. Patch 4 and patch 5 are the ones do the actual work. Please find more details in each patch description.

Vaclav Zindulka tested this patchset and his large ruleset with over 13k qdiscs defined got from 22s to 520ms.

---

Cong Wang (5):
net_sched: use qdisc_reset() in qdisc_destroy()
net_sched: add tracepoints for qdisc_reset() and qdisc_destroy()
net_sched: add a tracepoint for qdisc creation
net_sched: avoid resetting active qdisc for multiple times
net_sched: get rid of unnecessary dev_qdisc_reset()

 include/trace/events/qdisc.h | 75 ++++++++++++++++++++++++++++++++++++
 net/sched/sch_api.c          |  3 ++
 net/sched/sch_generic.c      | 75 +++++++++++++++---------------------
 3 files changed, 110 insertions(+), 43 deletions(-)
Signature · 1 line
2.26.2