Skip to content

scsi: ufs: cleanup ufs initialization

Bean Huo linux-scsi lkml 5 versions – Applied

Status from this message: Applied to 5.9/scsi-queue, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 2 repliesApplied
  2. v4 posting 2/25 patches 4 repliesSuperseded
  3. v4 posting 1/24 patches 7 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches13 repliesSuperseded
v11 patch0 repliesSuperseded

Changes in v5 from the cover letter

1. Rebased patch
2. In the patch 3/5, change "param_size > buff_len" to "(param_offset + param_size) > buff_len"

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/5scsi: ufs: remove max_t in ufs_get_device_descdrivers/scsi/ufs/ufshcd.c+1 -40 replies
2/5scsi: ufs: delete ufshcd_read_desc()drivers/scsi/ufs/ufshcd.c+8 -190 replies
3/5scsi: ufs: fix potential access NULL pointer while memcpydrivers/scsi/ufs/ufshcd.c+2 -20 replies
4/5scsi: ufs: cleanup ufs initialization pathdrivers/scsi/ufs/ufs.h drivers/scsi/ufs/ufs_bsg.c drivers/scsi/ufs/ufshcd.c +1 more+38 -1610 replies
5/5scsi: ufs: add compatibility with 3.1 UFS unit descriptor lengthdrivers/scsi/ufs/ufs.h drivers/scsi/ufs/ufshcd.c+9 -30 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchAvri AltmanBart van AsscheStanley Chu
1/5A-b R-b
2/5R-b R-b R-b
3/5
4/5R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [RESENT PATCH v5 0/5] scsi: ufs: cleanup ufs initialization

From: Bean Huo <[email protected]>

Resent this patchset since [email protected] and [email protected] rejected my email

Cleanup UFS descriptor length initialization, and delete some unnecessary code.

Changelog:
v4 - v5:
1. Rebased patch
2. In the patch 3/5, change "param_size > buff_len" to "(param_offset + param_size) > buff_len"

v3 - v4:
1. add desc_id >= QUERY_DESC_IDN_MAX check in patch 4/5 (Avri Altman)
2. update buff_len to hold the true descriptor size in 4/5 (Avri Altman)
3. add new patch 3/5

v2 - v3:
1. Fix typo in the commit message (Avri Altman & Bart van Assche)
2. Delete ufshcd_init_desc_sizes() in patch 3/4 (Stanley Chu)
3. Remove max_t() and buff_len in patch 1/4 (Bart van Assche)
4. Add patch 4/4 to compatable with 3.1 UFS unit descriptor length

v1 - v2:
1. split patch
2. fix one compiling WARNING (Reported-by: kbuild test robot <[email protected]>)

Bart van Assche (1):
scsi: ufs: remove max_t in ufs_get_device_desc

Bean Huo (4):
scsi: ufs: delete ufshcd_read_desc()
scsi: ufs: fix potential access NULL pointer while memcpy
scsi: ufs: cleanup ufs initialization path
scsi: ufs: add compatibility with 3.1 UFS unit descriptor length

 drivers/scsi/ufs/ufs.h     |  11 +-
 drivers/scsi/ufs/ufs_bsg.c |   5 +-
 drivers/scsi/ufs/ufshcd.c  | 207 +++++++++----------------------------
 drivers/scsi/ufs/ufshcd.h  |  16 +--
 4 files changed, 54 insertions(+), 185 deletions(-)
Signature · 1 line
2.17.1