Skip to content

xfs_repair: catch things that xfs_check misses

Darrick J. Wong linux-xfs 2 versions – In review

Get series with b4
b4 am 159107190111.313760.8056083399475334567.stgit@magnolia

Versions newest first · linked by author and title

  1. v2 Latest17 patches 1 replyIn review
  2. v11 patch 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17xfs_quota: fix unsigned int id comparisonsquota/edit.c+11 -111 reply
2/17xfs_repair: fix missing dir buffer corruption checksrepair/da_util.c repair/dir2.c+37 -90 replies
3/17xfs_repair: warn when we would have rebuilt a directoryrepair/phase6.c+3 -00 replies
4/17xfs_repair: check for AG btree records that would wrap aroundrepair/scan.c+6 -30 replies
5/17xfs_repair: fix bnobt and refcountbt record order checksrepair/scan.c+2 -20 replies
6/17xfs_repair: check for out-of-order inobt recordsrepair/scan.c+10 -00 replies
7/17xfs_repair: fix rmapbt record order checkrepair/scan.c+7 -50 replies
8/17xfs_repair: tag inobt vs finobt errors properlyrepair/scan.c+26 -100 replies
9/17xfs_repair: complain about bad interior btree pointerslibxfs/libxfs_api_defs.h repair/scan.c+41 -150 replies
10/17xfs_repair: convert to libxfs_verify_agbnolibxfs/libxfs_api_defs.h repair/dinode.c repair/dinode.h +1 more+24 -290 replies
11/17xfs_repair: refactor verify_dfsbno_rangelibxfs/libxfs_api_defs.h repair/dinode.c+10 -170 replies
12/17xfs_repair: remove verify_dfsbnorepair/attr_repair.c repair/dinode.c repair/dinode.h +2 more+8 -300 replies
13/17xfs_repair: remove verify_aginumlibxfs/libxfs_api_defs.h repair/dino_chunks.c repair/dinode.c +2 more+6 -610 replies
14/17xfs_repair: mark entire free space btree record as free1repair/scan.c+1 -10 replies
15/17xfs_repair: complain about free space only seen by one btreerepair/phase4.c+6 -10 replies
16/17xfs_repair: complain about extents in unknown staterepair/phase4.c+2 -20 replies
17/17xfs_repair: complain about any nonzero inprogress value, not just 1repair/sb.c+1 -20 replies

Reviews trailers per patch

All 17 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/17R-b
2/17R-b
3/17R-b
4/17R-b
5/17R-b
6/17R-b
7/17R-b
8/17R-b
9/17R-b
10/17R-b
11/17R-b
12/17R-b
13/17R-b
14/17R-b
15/17R-b
16/17R-b
17/17R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/17] xfs_repair: catch things that xfs_check misses

Hi all,

A long-time goal of mine is to get rid of xfs_check from fstests, because it is deprecated, adds quite a bit of runtime to the test suite, and consumes memory like crazy. We've not been able to do that for lack of even a basic field-by-field corruption detection comparison between check and repair, so I temporarily modified the dangerous_repair tests to warn when check finds something but repair says clean.

The patches below teach xfs_repair to complain about things that it previously did not catch but xfs_check did. The one remaining gap is the lack of quota counter checking, which will be sent in a separate series once I've worked out all the bugs.

v2: mostly minor updates and add a bunch of RVB tags. Also pick up the one quota fix because why not...

If you're going to start using this mess, you probably ought to just pull from my git trees, which are linked below.

This is an extraordinary way to destroy everything. Enjoy! Comments and questions are, as always, welcome.

--D

xfsprogs git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=check-vs-repair

---
 libxfs/libxfs_api_defs.h |    4 +
 quota/edit.c             |   22 +++---
 repair/attr_repair.c     |    2 -
 repair/da_util.c         |   25 +++++--
 repair/dino_chunks.c     |    6 +-
 repair/dinode.c          |  109 +++----------------------------
 repair/dinode.h          |   14 ----
 repair/dir2.c            |   21 ++++++
 repair/phase4.c          |   11 ++-
 repair/phase6.c          |    3 +
 repair/prefetch.c        |    9 +--
 repair/sb.c              |    3 -
 repair/scan.c            |  160 ++++++++++++++++++++++++++++++++--------------
 13 files changed, 196 insertions(+), 193 deletions(-)