Skip to content

vmxnet3: upgrade to version 4

Ronak Doshi lkml netdev 4 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 1 replyIn review
  2. v34 patches 1 replySuperseded
  3. v24 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches1 replySuperseded

Changes in v4 from the cover letter

- Replaced BUG_ON() with WARN_ON_ONCE()

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4vmxnet3: prepare for version 4 changesdrivers/net/vmxnet3/Makefile drivers/net/vmxnet3/upt1_defs.h drivers/net/vmxnet3/vmxnet3_defs.h +3 more+9 -60 replies
2/4vmxnet3: add support to get/set rx flow hashdrivers/net/vmxnet3/vmxnet3_defs.h drivers/net/vmxnet3/vmxnet3_drv.c drivers/net/vmxnet3/vmxnet3_ethtool.c +1 more+272 -20 replies
3/4vmxnet3: add geneve and vxlan tunnel offload supportdrivers/net/vmxnet3/upt1_defs.h drivers/net/vmxnet3/vmxnet3_defs.h drivers/net/vmxnet3/vmxnet3_drv.c +2 more+161 -330 replies
4/4vmxnet3: update to version 4drivers/net/vmxnet3/vmxnet3_drv.c drivers/net/vmxnet3/vmxnet3_int.h+8 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 net-next 0/4] vmxnet3: upgrade to version 4

vmxnet3 emulation has recently added several new features which includes offload support for tunnel packets, support for new commands the driver can issue to emulation, change in descriptor fields, etc. This patch series extends the vmxnet3 driver to leverage these new features.

Compatibility is maintained using existing vmxnet3 versioning mechanism as follows:
- new features added to vmxnet3 emulation are associated with new vmxnet3 version viz. vmxnet3 version 4.
- emulation advertises all the versions it supports to the driver.
- during initialization, vmxnet3 driver picks the highest version number supported by both the emulation and the driver and configures emulation to run at that version.

In particular, following changes are introduced:

Patch 1:
This patch introduces utility macros for vmxnet3 version 4 comparison and updates Copyright information.

Patch 2:
This patch implements get_rss_hash_opts and set_rss_hash_opts methods to allow querying and configuring different Rx flow hash configurations which can be used to support UDP/ESP RSS.

Patch 3:
This patch introduces segmentation and checksum offload support for encapsulated packets. This avoids segmenting and calculating checksum for each segment and hence gives performance boost.

Patch 4:
With all vmxnet3 version 4 changes incorporated in the vmxnet3 driver, with this patch, the driver can configure emulation to run at vmxnet3 version 4.

Changes in v3 -> v4:
- Replaced BUG_ON() with WARN_ON_ONCE()

Changes in v2 -> v3:
- fixed get_rss_hash_opts to return correct values for udp rss

Changes in v2:
- Fixed compilation issue due to missing closed brace
- added fallthrough comment

Ronak Doshi (4):
vmxnet3: prepare for version 4 changes
vmxnet3: add support to get/set rx flow hash
vmxnet3: add geneve and vxlan tunnel offload support
vmxnet3: update to version 4

 drivers/net/vmxnet3/Makefile          |   2 +-
 drivers/net/vmxnet3/upt1_defs.h       |   5 +-
 drivers/net/vmxnet3/vmxnet3_defs.h    |  31 ++--
 drivers/net/vmxnet3/vmxnet3_drv.c     | 164 ++++++++++++++++++---
 drivers/net/vmxnet3/vmxnet3_ethtool.c | 263 +++++++++++++++++++++++++++++++++-
 drivers/net/vmxnet3/vmxnet3_int.h     |  25 +++-
 6 files changed, 448 insertions(+), 42 deletions(-)
Signature · 1 line
2.11.0