Skip to content

sysctl: spring cleaning

Luis Chamberlain dri-devel intel-gfx linuxppc-dev lkml ocfs2-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13sysctl: add new register_sysctl_subdir() helperinclude/linux/sysctl.h kernel/sysctl.c+48 -04 replies
2/13cdrom: use new sysctl subdir helper register_sysctl_subdir()drivers/cdrom/cdrom.c+2 -211 reply
3/13hpet: use new sysctl subdir helper register_sysctl_subdir()drivers/char/hpet.c+1 -210 replies
4/13i915: use new sysctl subdir helper register_sysctl_subdir()drivers/gpu/drm/i915/i915_perf.c+1 -210 replies
5/13macintosh/mac_hid.c: use new sysctl subdir helper register_sysctl_subdir()drivers/macintosh/mac_hid.c+2 -230 replies
6/13ocfs2: use new sysctl subdir helper register_sysctl_subdir()fs/ocfs2/stackglue.c+4 -233 replies
7/13test_sysctl: use new sysctl subdir helper register_sysctl_subdir()lib/test_sysctl.c+2 -210 replies
8/13inotify: simplify sysctl declaration with register_sysctl_subdir()fs/notify/inotify/inotify_user.c include/linux/inotify.h kernel/sysctl.c+10 -150 replies
9/13firmware_loader: simplify sysctl declaration with register_sysctl_subdir()drivers/base/firmware_loader/fallback.c drivers/base/firmware_loader/fallback.h drivers/base/firmware_loader/fallback_table.c +2 more+35 -103 replies
10/13eventpoll: simplify sysctl declaration with register_sysctl_subdir()fs/eventpoll.c include/linux/poll.h include/linux/sysctl.h +1 more+9 -110 replies
11/13random: simplify sysctl declaration with register_sysctl_subdir()drivers/char/random.c include/linux/sysctl.h kernel/sysctl.c+12 -82 replies
12/13sysctl: add helper to register empty subdirinclude/linux/sysctl.h kernel/sysctl.c+20 -33 replies
13/13fs: move binfmt_misc sysctl to its own filefs/binfmt_misc.c kernel/sysctl.c+1 -72 replies

Reviews trailers per patch

1 of 13 patches has a Reviewed-by or Acked-by.

PatchKees Cook
1/13
2/13
3/13
4/13
5/13
6/13
7/13
8/13
9/13
10/13
11/13
12/13R-b
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/13] sysctl: spring cleaning

Me and Xiaoming are working on some kernel/sysctl.c spring cleaning. During a recent linux-next merge conflict it became clear that the kitchen sink on kernel/sysctl.c creates too many conflicts, and so we need to do away with stuffing everyone's knobs on this one file.

This is part of that work. This is not expected to get merged yet, but since our delta is pretty considerable at this point, we need to piece meal this and collect reviews for what we have so far. This follows up on some of his recent work.

This series focuses on a new helper to deal with subdirectories and empty subdirectories. The terminology that we will embrace will be that things like "fs", "kernel", "debug" are based directories, and directories underneath this are subdirectories.

In this case, the cleanup ends up also trimming the amount of code we have for sysctls.

If this seems reasonable we'll kdocify this a bit too.

This code has been boot tested without issues, and I'm letting 0day do its thing to test against many kconfig builds. If you however spot any issues please let us know.

Luis Chamberlain (9):
sysctl: add new register_sysctl_subdir() helper
cdrom: use new sysctl subdir helper register_sysctl_subdir()
hpet: use new sysctl subdir helper register_sysctl_subdir()
i915: use new sysctl subdir helper register_sysctl_subdir() macintosh/mac_hid.c: use new sysctl subdir helper
register_sysctl_subdir()
ocfs2: use new sysctl subdir helper register_sysctl_subdir()
test_sysctl: use new sysctl subdir helper register_sysctl_subdir()
sysctl: add helper to register empty subdir
fs: move binfmt_misc sysctl to its own file

Xiaoming Ni (4):
inotify: simplify sysctl declaration with register_sysctl_subdir()
firmware_loader: simplify sysctl declaration with
register_sysctl_subdir()
eventpoll: simplify sysctl declaration with register_sysctl_subdir()
random: simplify sysctl declaration with register_sysctl_subdir()

 drivers/base/firmware_loader/fallback.c       |  4 +
 drivers/base/firmware_loader/fallback.h       | 11 +++
 drivers/base/firmware_loader/fallback_table.c | 22 ++++-
 drivers/cdrom/cdrom.c                         | 23 +----
 drivers/char/hpet.c                           | 22 +----
 drivers/char/random.c                         | 14 +++-
 drivers/gpu/drm/i915/i915_perf.c              | 22 +----
 drivers/macintosh/mac_hid.c                   | 25 +-----
 fs/binfmt_misc.c                              |  1 +
 fs/eventpoll.c                                | 10 ++-
 fs/notify/inotify/inotify_user.c              | 11 ++-
 fs/ocfs2/stackglue.c                          | 27 +-----
 include/linux/inotify.h                       |  3 -
 include/linux/poll.h                          |  2 -
 include/linux/sysctl.h                        | 21 ++++-
 kernel/sysctl.c                               | 84 +++++++++++--------
 lib/test_sysctl.c                             | 23 +----
 17 files changed, 144 insertions(+), 181 deletions(-)
Signature · 1 line
2.26.2