Skip to content

Refactor handling flow of KVM_SET_CPUID*

Xiaoyao Li kvm lkml 4 versions – Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 2 repliesApplied
  2. v38 patches 12 repliesApplied
  3. v27 patches 9 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v16 patches2 repliesSuperseded

Changes in v4 from the cover letter

- remove 4 queued patches
- rebased to kvm/queue: c16ced9cc67a "x86/kvm/vmx: Use native read/write_cr2()"
- fix one bug in v3 to call kvfree(cpuid_entries) in kvm_vcpu_ioctl_set_cpuid()
- rename "update_vcpu_model" to "vcpu_after_set_cpuid" [Paolo]
- Add a new patch to extrace kvm_update_cpuid_runtime()

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/5KVM: x86: Introduce kvm_check_cpuid()arch/x86/kvm/cpuid.c arch/x86/kvm/cpuid.h+36 -210 replies
2/5KVM: x86: Extract kvm_update_cpuid_runtime() from kvm_update_cpuid()arch/x86/kvm/cpuid.c arch/x86/kvm/cpuid.h arch/x86/kvm/lapic.c +1 more+34 -241 reply
3/5KVM: x86: Rename kvm_update_cpuid() to kvm_vcpu_after_set_cpuid()arch/x86/kvm/cpuid.c+3 -30 replies
4/5KVM: x86: Rename cpuid_update() callback to vcpu_after_set_cpuid()arch/x86/include/asm/kvm_host.h arch/x86/kvm/cpuid.c arch/x86/kvm/svm/svm.c +2 more+9 -80 replies
5/5KVM: x86: Move kvm_x86_ops.vcpu_after_set_cpuid() into kvm_vcpu_after_set_cpuid()arch/x86/kvm/cpuid.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/5] Refactor handling flow of KVM_SET_CPUID*

4 Patches of v3 has been queued into kvm/queue branch. This v4 contains the rest to refactor the flow of KVM_SET_CPUID* as:

1. cpuid check: check if userspace provides legal CPUID settings;

2. cpuid update: Update userspace provided CPUID settings. It currently only contains kvm_update_cpuid_runtime, which updates special CPUID bits based on the vcpu state, e.g., OSXSAVE, OSPKE. In the future, we can re-introduce kvm_update_cpuid() if KVM needs to force on/off some bits.

3. update vcpu states: Update vcpu states/settings based on the final updated CPUID settings.

v4:
- remove 4 queued patches
- rebased to kvm/queue: c16ced9cc67a "x86/kvm/vmx: Use native read/write_cr2()"
- fix one bug in v3 to call kvfree(cpuid_entries) in kvm_vcpu_ioctl_set_cpuid()
- rename "update_vcpu_model" to "vcpu_after_set_cpuid" [Paolo]
- Add a new patch to extrace kvm_update_cpuid_runtime()

v3:
https://lkml.kernel.org/r/[email protected]
- Add a note in KVM api doc to state the previous CPUID configuration is not reliable if current KVM_SET_CPUID* fails [Jim]
- Adjust Patch 2 to reduce code churn [Sean]
- Commit message refine to add more justification [Sean]
- Add a new patch 7

v2:
https://lkml.kernel.org/r/[email protected]
- rebase to kvm/queue: a037ff353ba6 ("Merge branch 'kvm-master' into HEAD")
- change the name of kvm_update_state_based_on_cpuid() to kvm_update_vcpu_model() [Sean]
- Add patch 5 to rename kvm_x86_ops.cpuid_date() to kvm_x86_ops.update_vcpu_model()

v1:
https://lkml.kernel.org/r/[email protected]

Xiaoyao Li (5):
KVM: x86: Introduce kvm_check_cpuid()
KVM: x86: Extract kvm_update_cpuid_runtime() from kvm_update_cpuid()
KVM: x86: Rename kvm_update_cpuid() to kvm_vcpu_after_set_cpuid()
KVM: x86: Rename cpuid_update() callback to vcpu_after_set_cpuid()
KVM: x86: Move kvm_x86_ops.vcpu_after_set_cpuid() into
kvm_vcpu_after_set_cpuid()

 arch/x86/include/asm/kvm_host.h |  2 +-
 arch/x86/kvm/cpuid.c            | 99 +++++++++++++++++++++------------
 arch/x86/kvm/cpuid.h            |  2 +-
 arch/x86/kvm/lapic.c            |  2 +-
 arch/x86/kvm/svm/svm.c          |  4 +-
 arch/x86/kvm/vmx/nested.c       |  3 +-
 arch/x86/kvm/vmx/vmx.c          |  4 +-
 arch/x86/kvm/x86.c              | 10 ++--
 8 files changed, 76 insertions(+), 50 deletions(-)
Signature · 1 line
2.18.4