Skip to content

vhost, docs: convert to pin_user_pages(), new "case 5"

John Hubbard kvm linux-doc linux-fsdevel linux-mm lkml netdev virtualization 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 6 repliesSuperseded 1 of 2 applied

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2docs: mm/gup: pin_user_pages.rst: add a "case 5"Documentation/core-api/pin_user_pages.rst+18 -01 reply
2/2vhost: convert get_user_pages() --> pin_user_pages()drivers/vhost/vhost.c+2 -31 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJan KaraPankaj Gupta
1/2R-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] vhost, docs: convert to pin_user_pages(), new "case 5"

This is based on Linux 5.7, plus one prerequisite patch:
"mm/gup: update pin_user_pages.rst for "case 3" (mmu notifiers)" [1]

Changes since v1: removed references to set_page_dirty*(), in response to Souptick Joarder's review (thanks!).

Cover letter for v1, edited/updated slightly:

It recently became clear to me that there are some get_user_pages*() callers that don't fit neatly into any of the four cases that are so far listed in pin_user_pages.rst. vhost.c is one of those.

Add a Case 5 to the documentation, and refer to that when converting vhost.c.

Thanks to Jan Kara for helping me (again) in understanding the interaction between get_user_pages() and page writeback [2].

Note that I have only compile-tested the vhost.c patch, although that does also include cross-compiling for a few other arches. Any run-time testing would be greatly appreciated.

[1] https://lore.kernel.org/r/[email protected]
[2] https://lore.kernel.org/r/[email protected]

John Hubbard (2):
docs: mm/gup: pin_user_pages.rst: add a "case 5"
vhost: convert get_user_pages() --> pin_user_pages()

 Documentation/core-api/pin_user_pages.rst | 18 ++++++++++++++++++
 drivers/vhost/vhost.c                     |  5 ++---
 2 files changed, 20 insertions(+), 3 deletions(-)

base-commit: 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162

Signature · 1 line
2.26.2