backlight: backlight updates
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest19 patches 4 repliesIn review
- v420 patches 17 repliesSuperseded
- v313 patches 7 repliesSuperseded
Changes in v5 from the cover letter
- Added r-b's
- Updated cr_bllcd to use gpio-backlight semantics
- Various editorial updates to changelogs
- Rebased on top of Lee's backlight tree
- Dropped "make of_find_backlight_by_node() static"
The change depends on drm-misc-next.
Will be re-send when the changes hits the backlight tree (We could have done this in other ways, but it is easier to just wait)
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | backlight: refactor fb_notifier_callback()drivers/ | +22 | 0 replies | |
| 2/19 | backlight: add backlight_is_blank()include/ | +19 | 0 replies | |
| 3/19 | backlight: improve backlight_ops documentationinclude/ | +53 | 0 replies | |
| 4/19 | backlight: improve backlight_properties documentationinclude/ | +85 | 0 replies | |
| 5/19 | backlight: improve backlight_device documentationinclude/ | +49 | 0 replies | |
| 6/19 | backlight: document inline functions in backlight.hinclude/ | +16 | 0 replies | |
| 7/19 | backlight: document enums in backlight.hinclude/ | +72 | 0 replies | |
| 8/19 | backlight: remove the unused backlight_bl driverdrivers/ drivers/ drivers/ +1 more | +0 | 0 replies | |
| 9/19 | backlight: drop extern from prototypesinclude/ | +19 | 0 replies | |
| 10/19 | backlight: add overview and update existing docdrivers/ | +98 | 0 replies | |
| 11/19 | backlight: wire up kernel-doc documentationDocumentation/ Documentation/ | +13 | 0 replies | |
| 12/19 | backlight: introduce backlight_get_brightness()include/ | +19 | 0 replies | |
| 13/19 | backlight: as3711_bl: simplify update_statusdrivers/ | +2 | 0 replies | |
| 14/19 | backlight: cr_bllcd: introduce gpio-backlight semanticsdrivers/ | +9 | 2 replies | |
| 15/19 | backlight: gpio_backlight: simplify update_status()drivers/ | +2 | 0 replies | |
| 16/19 | backlight: jornada720_bl: introduce backlight_is_blank()drivers/ | +1 | 0 replies | |
| 17/19 | backlight: use backlight_get_brightness()drivers/ drivers/ drivers/ +16 more | +19 | 0 replies | |
| 18/19 | backlight: drop backlight_put()drivers/ include/ | +5 | 0 replies | |
| 19/19 | backlight: make of_find_backlight staticdrivers/ include/ | +1 | 0 replies |
Reviews trailers per patch
All 19 patches have a Reviewed-by or Acked-by.
| Patch | Daniel Thompson | Emil Velikov | Jingoo Han | Peter Ujfalusi | Daniel Vetter |
|---|---|---|---|---|---|
| 1/19 | R-b | R-b | |||
| 2/19 | R-b | R-b | R-b | R-b | |
| 3/19 | R-b | R-b | |||
| 4/19 | R-b | R-b | |||
| 5/19 | R-b | R-b | R-b | ||
| 6/19 | R-b | R-b | |||
| 7/19 | R-b | R-b | |||
| 8/19 | R-b | R-b | |||
| 9/19 | R-b | R-b | |||
| 10/19 | R-b | R-b | |||
| 11/19 | R-b | R-b | |||
| 12/19 | R-b | ||||
| 13/19 | R-b | ||||
| 14/19 | R-b | ||||
| 15/19 | R-b | ||||
| 16/19 | R-b | ||||
| 17/19 | R-b | ||||
| 18/19 | R-b | ||||
| 19/19 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v5 0/19] backlight: backlight updates
Hi all.
Follow-up on v4 - with only a few changes listed below and in the individual patches.
Thanks for all the reviews and the feedback on the patches!
I am planning a follow-up on this patchset to update the backlight drivers all over to use backlight_get_brightness() and backlight_is_blank() as appropriate.
v5:
- Added r-b's
- Updated cr_bllcd to use gpio-backlight semantics
- Various editorial updates to changelogs
- Rebased on top of Lee's backlight tree
- Dropped "make of_find_backlight_by_node() static"
The change depends on drm-misc-next.
Will be re-send when the changes hits the backlight tree (We could have done this in other ways, but it is easier to just wait)
v4:
- Introduced backlight_get_brightness based on feedback from Emil.
- Properly described the rationale behind more restrictive locking use I checked that locking was not used outside backlight core by renaming the lock fields.
As it is not used seems OK to restrict use to the core.
- Introducing backlight_get_brightness invalidated
some patches and I did a bit finer split to ease review.
- Added acks
- A few small adjustments documented in the individual patches
v3:
- Dropped video patch that was reviewd and thus applied
- Updated kernel-doc so all fields now have a short intro
- Improved readability in a lot of places, thanks to review feedback from Daniel - thanks!
- Added better intro to backlight
- Added acks
Several other smaller changes documented in the patches.
I left out patches to make functions static as there are dependencies to drm-misc-next for these.
v2:
- Dropped drm patches that was reviewed and thus applied (Thanks Tomi)
- Updated backligth_is_blank() based on Daniel's feedback
- Dropped EXPORT_SYMBOL that was no longer relevant
- Reordered patches, so patches with no external dependencies comes first
- Updated the description that follows.
The following series touches a lot of backlight things.
Starts with a small refactoring in backligth.c to remove some indents. This increases the readability and no functional changes.
Then two new helpers backlight_is_blank(), backlight_get_brightness() are added. These helpers simplifies the implementation of update_status() in the backlight drivers where they are used.
Then while surfing the code I missed some documentation. So I got a bit carried away and updated the documentation for the backlight core and added it to kernel-doc. The documentation express my current understanding. Everything from spelling errors to outright wrong content shall be anticipated - so please review!
We are all best helped if the documentation is correct and up-to-date and it is readable.
In this process I identified that the backlight_bl driver was no longer in use - so drop it.
Everything builds, but so far no run-time testing.
Sam
Sam Ravnborg (19):
backlight: refactor fb_notifier_callback()
backlight: add backlight_is_blank()
backlight: improve backlight_ops documentation
backlight: improve backlight_properties documentation
backlight: improve backlight_device documentation
backlight: document inline functions in backlight.h
backlight: document enums in backlight.h
backlight: remove the unused backlight_bl driver
backlight: drop extern from prototypes
backlight: add overview and update existing doc
backlight: wire up kernel-doc documentation
backlight: introduce backlight_get_brightness()
backlight: as3711_bl: simplify update_status
backlight: cr_bllcd: introduce gpio-backlight semantics
backlight: gpio_backlight: simplify update_status()
backlight: jornada720_bl: introduce backlight_is_blank()
backlight: use backlight_get_brightness()
backlight: drop backlight_put()
backlight: make of_find_backlight static
Documentation/gpu/backlight.rst | 12 + Documentation/gpu/index.rst | 1 + drivers/video/backlight/88pm860x_bl.c | 13 +- drivers/video/backlight/Kconfig | 8 - drivers/video/backlight/Makefile | 1 - drivers/video/backlight/adp5520_bl.c | 10 +- drivers/video/backlight/adp8860_bl.c | 10 +- drivers/video/backlight/adp8870_bl.c | 10 +- drivers/video/backlight/as3711_bl.c | 11 +- drivers/video/backlight/backlight.c | 208 +++++++++------- drivers/video/backlight/bd6107.c | 7 +- drivers/video/backlight/corgi_lcd.c | 8 +- drivers/video/backlight/cr_bllcd.c | 25 +- drivers/video/backlight/da903x_bl.c | 13 +- drivers/video/backlight/ep93xx_bl.c | 8 +- drivers/video/backlight/generic_bl.c | 110 --------- drivers/video/backlight/gpio_backlight.c | 17 +- drivers/video/backlight/hp680_bl.c | 6 +- drivers/video/backlight/jornada720_bl.c | 2 +- drivers/video/backlight/kb3886_bl.c | 6 +- drivers/video/backlight/led_bl.c | 7 +- drivers/video/backlight/lm3533_bl.c | 8 +- drivers/video/backlight/locomolcd.c | 6 +- drivers/video/backlight/lv5207lp.c | 7 +- drivers/video/backlight/max8925_bl.c | 13 +- drivers/video/backlight/pwm_bl.c | 7 +- drivers/video/backlight/qcom-wled.c | 7 +- drivers/video/backlight/tps65217_bl.c | 10 +- drivers/video/backlight/wm831x_bl.c | 13 +- include/linux/backlight.h | 399 +++++++++++++++++++++++++------ 30 files changed, 497 insertions(+), 466 deletions(-)