Skip to content

writeback: Lazytime handling fix and cleanups

Jan Kara linux-fsdevel linux-xfs stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 9 repliesIn review
  2. v13 patches 9 repliesSuperseded

Changes in v2 from the cover letter

* Split off locking change for i_io_list manipulation to a separate patch
* Renamed older_than_this to dirtied_before
* Renamed __redirty_tail() to redirty_tail_locked()
* Other minor style fixes

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4writeback: Protect inode->i_io_list with inode->i_lockfs/fs-writeback.c+17 -52 replies
2/4writeback: Avoid skipping inode writebackfs/fs-writeback.c include/linux/fs.h+18 -74 replies
3/4writeback: Fix sync livelock due to b_dirty_time processingfs/fs-writeback.c include/trace/events/writeback.h+23 -341 reply
4/4writeback: Drop I_DIRTY_TIME_EXPIREfs/ext4/inode.c fs/fs-writeback.c fs/xfs/libxfs/xfs_trans_inode.c +2 more+14 -222 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigMartijn Coenen
1/4R-b R-b
2/4R-b R-b T-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH 0/4 v2] writeback: Lazytime handling fix and cleanups

Hello,

this patch series fixes an issue with handling of lazy inode timestamp writeback which could result in missed background writeback of an inode or missed update of inode timestamps during sync(2). It also somewhat simplifies the writeback code handling of lazy inode timestamp updates.

Changes since v1:
* Split off locking change for i_io_list manipulation to a separate patch
* Renamed older_than_this to dirtied_before
* Renamed __redirty_tail() to redirty_tail_locked()
* Other minor style fixes

Honza

Previous versions: