Skip to content

RFC Add basic support for PE binary format

Rémi Bernon lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2perf dso: Use libbfd to read build_id and .gnu_debuglink sectiontools/perf/util/symbol-elf.c+62 -31 reply
2/2perf symbols: Try reading the symbol table with libbfdtools/perf/util/symbol.c+124 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/2] Add basic support for PE binary format

Hi,

I'm currently trying to improve compatibility between Wine and perf, and I would like to have you opinion on this approach.

The main problem is that Wine uses PE binary format for most of its code (and of course the Windows application it runs are also using PE binary format), and perf is currently unable to parse them to get the symbol table or even to find the debug file location from build_id or .gnu_debuglink section.

I know that there's the possibility to use a perfmap file to map address ranges to symbols, but it requires the runtime to generate it. And in this case the information is already there in the PE files, just not in a format that perf supports.

I also have some alternate ways to make it work, using perf-specific tweaks in Wine for instance. But I believe that having better support of PE binary format in perf could be generally useful, although for now Wine is the only use-case I know.

This first starts using libbfd to parse the build_id and .gnu_debuglink section, to make sure perf gets the debug file location even if the code modules are in PE binary format.

Then, as Wine also generates debug files in PE or PDB format by default, it also tries to use libbfd to parse the symbol table from the debug file if libelf failed.

Of course, advanced features will still lack, but this makes it possible to have perf report symbols and source-level annotations for any Windows code running in Wine, assuming the modules aren't stripped.

Cheers,

Rémi Bernon (2):
perf dso: Use libbfd to read build_id and .gnu_debuglink section perf symbols: Try reading the symbol table with libbfd

 tools/perf/util/symbol-elf.c |  65 +++++++++++++++++-
 tools/perf/util/symbol.c     | 124 +++++++++++++++++++++++++++++++++++
 2 files changed, 186 insertions(+), 3 deletions(-)
Signature · 1 line
2.26.1