Skip to content

serial: core: fix up sysrq regressions

Johan Hovold linux-serial lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 8 repliesIn review
  2. v14 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- inline uart_unlock_and_check_sysrq() along with the other helpers (restoring the interrupt state in a helper was never an issue)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Revert "serial: core: Refactor uart_unlock_and_check_sysrq()"drivers/tty/serial/serial_core.c include/linux/serial_core.h+15 -110 replies
2/3serial: core: fix sysrq overhead regressiondrivers/tty/serial/serial_core.c include/linux/serial_core.h+100 -1024 replies
3/3serial: core: drop redundant sysrq checksinclude/linux/serial_core.h+2 -21 reply

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy ShevchenkoDmitry Safonov
SeriesR-b
1/3
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] serial: core: fix up sysrq regressions

This series fixes a few regressions introduced by the recent sysrq rework that went into 5.6.

The fix for the unnecessary per-character overhead probably could have been marked for stable but I left that decision to the maintainers as it is a bit intrusive (although mostly shuffling code around).

Johan

Changes in v2
- inline uart_unlock_and_check_sysrq() along with the other helpers (restoring the interrupt state in a helper was never an issue)

Johan Hovold (3):
Revert "serial: core: Refactor uart_unlock_and_check_sysrq()"
serial: core: fix sysrq overhead regression
serial: core: drop redundant sysrq checks

 drivers/tty/serial/serial_core.c |  96 +----------------------------
 include/linux/serial_core.h      | 102 +++++++++++++++++++++++++++++--
 2 files changed, 100 insertions(+), 98 deletions(-)
Signature · 1 line
2.26.2