Skip to content

RFC replace runtime slub_debug toggling with more capable boot parameter

Vlastimil Babka linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5mm, slub: extend slub_debug syntax for multiple blocksDocumentation/admin-guide/kernel-parameters.txt Documentation/vm/slub.rst mm/slub.c+144 -522 replies
2/5mm, slub: make some slub_debug related attributes read-onlyDocumentation/vm/slub.rst mm/slub.c+20 -542 replies
3/5mm, slub: remove runtime allocation order changesmm/slub.c+1 -182 replies
4/5mm, slub: make remaining slub_debug related attributes read-onlyDocumentation/vm/slub.rst mm/slub.c+5 -642 replies
5/5mm, slub: make reclaim_account attribute read-onlymm/slub.c+1 -102 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchKees CookRoman Gushchin
1/5R-b
2/5R-b A-b
3/5R-b A-b
4/5R-b A-b
5/5R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 0/5] replace runtime slub_debug toggling with more capable boot parameter

Hi,

we had recently reports [1,2] of troubles with runtime writes to various SLUB per-cache sysfs files related to slub_debug or tuning leading to crashes. I have inspected all those writable files and the rather unfortunate result is that most of them are made read-only by this patchset, as fixing the issues doesn't seem viable. Details for each are given in each patch. I expect some resistance, hence the RFC.

The runtime toggles were however necessary for the use case described in [3], so the first patch extends the slub_debug boot parameter syntax to achieve the same configuration without runtime toggles. That should hopefully make the changes more feasible.

[1] https://lkml.kernel.org/r/[email protected]
[2] https://lore.kernel.org/r/CAG48ez31PP--h6_FzVyfJ4H86QYczAFPdxtJHUEEan+7VJETAQ@mail.gmail.com
[3] https://lore.kernel.org/r/[email protected]

Vlastimil Babka (5):
mm, slub: extend slub_debug syntax for multiple blocks mm, slub: make some slub_debug related attributes read-only mm, slub: remove runtime allocation order changes
mm, slub: make remaining slub_debug related attributes read-only mm, slub: make reclaim_account attribute read-only

 .../admin-guide/kernel-parameters.txt         |   2 +-
 Documentation/vm/slub.rst                     |  36 +-
 mm/slub.c                                     | 315 ++++++++----------
 3 files changed, 163 insertions(+), 190 deletions(-)
Signature · 1 line
2.26.2