python: add mypy support to python/qemu
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest16 patches 4 repliesIn review
- v416 patches 3 repliesSuperseded
- v316 patches 17 repliesApplied
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 16 patches | 11 replies | Superseded |
v4 from the cover letter
- Rebased on "refactor shutdown" v4
- Fixed _qmp access for scripts that disable QMP
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | python/qmp.py: Define common typespython/ | +18 | 0 replies | |
| 2/16 | iotests.py: use qemu.qmp type aliasestests/ | +3 | 0 replies | |
| 3/16 | python/qmp.py: re-absorb MonitorResponseErrorpython/ python/ scripts/ | +21 | 0 replies | |
| 4/16 | python/qmp.py: Do not return None from cmd_objpython/ | +5 | 0 replies | |
| 5/16 | python/qmp.py: add casts to JSON deserializationpython/ | +6 | 0 replies | |
| 6/16 | python/qmp.py: add QMPProtocolErrorpython/ | +10 | 0 replies | |
| 7/16 | python/machine.py: Fix monitor address typingpython/ | +29 | 0 replies | |
| 8/16 | python/machine.py: reorder __init__python/ | +17 | 0 replies | |
| 9/16 | python/machine.py: Don't modify state in _base_args()python/ python/ | +18 | 0 replies | |
| 10/16 | python/machine.py: Handle None events in events_waitpython/ | +20 | 0 replies | |
| 11/16 | python/machine.py: use qmp.commandpython/ | +15 | 0 replies | |
| 12/16 | python/machine.py: Add _qmp access shimpython/ | +13 | 1 reply | |
| 13/16 | python/machine.py: fix _popen accesspython/ | +11 | 1 reply | |
| 14/16 | python/qemu: make 'args' style arguments immutablepython/ python/ | +29 | 0 replies | |
| 15/16 | iotests.py: Adjust HMP kwargs typingtests/ | +1 | 0 replies | |
| 16/16 | python/qemu: Add mypy type annotationspython/ python/ python/ +1 more | +98 | 1 reply |
Reviews trailers per patch
All 16 patches have a Reviewed-by or Acked-by.
| Patch | Kevin Wolf | Philippe Mathieu-Daudé |
|---|---|---|
| 1/16 | R-b | |
| 2/16 | R-b | |
| 3/16 | R-b | R-b |
| 4/16 | R-b | |
| 5/16 | R-b | |
| 6/16 | R-b | R-b |
| 7/16 | R-b | |
| 8/16 | R-b | R-b |
| 9/16 | R-b | |
| 10/16 | R-b | |
| 11/16 | R-b | |
| 12/16 | R-b | |
| 13/16 | R-b | |
| 14/16 | R-b | |
| 15/16 | R-b | |
| 16/16 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 00/16] python: add mypy support to python/qemu
Based-on: [email protected]
This series modifies the python/qemu library to comply with mypy --strict, pylint, and flake8.
This requires my "refactor shutdown" patch as a pre-requisite.
v5: (Things unchanged omitted)
003/16:[----] [-C] 'python/qmp.py: re-absorb MonitorResponseError' 009/16:[----] [-C] 'python/machine.py: Don't modify state in _base_args()' 012/16:[0004] [FC] 'python/machine.py: Add _qmp access shim' 013/16:[0002] [FC] 'python/machine.py: fix _popen access' 016/16:[0004] [FC] 'python/qemu: Add mypy type annotations'
-- Rebased on "refactor shutdown" v5
12: Dependent changes from more extensive shutdown() refactoring 13: Dependent changes; one less ._popen access.
16: Dependent changes; _post_shutdown return annotation fell down here.
wait annotation got bumped up to the previous series.
v4:
- Rebased on "refactor shutdown" v4
- Fixed _qmp access for scripts that disable QMP
v3:
005: Removed a cast, per Kevin Wolf's tip
010: Renamed with correct function name;
Rewrote docstring and added comments
016: Use SocketAddrT instead of Union[Tuple[str,str],str]
"v2":
- This version supports iotests 297
- Many patches merged by Phil are removed
- Replaces iotests.py type aliases with centralized ones (See patch 2)
- Imports etc are reworked to use the non-installable package layout instead. (Mostly important for patch 3)
Testing this out:
- You'll need Python3.6+
- I encourage you to use a virtual environment!
- You don't necessarily need these exact versions, but I didn't test the lower bounds, use older versions at your peril:
- pylint==2.5.0
- mypy=0.770
- flake8=3.7.8
Quoted 5 lines
cd ~/src/qemu/python/
flake8 qemu
mypy --strict qemu
cd qemu
pylint *.py
These should all 100% pass.
John Snow (16):
python/qmp.py: Define common types iotests.py: use qemu.qmp type aliases python/qmp.py: re-absorb MonitorResponseError python/qmp.py: Do not return None from cmd_obj python/qmp.py: add casts to JSON deserialization python/qmp.py: add QMPProtocolError python/machine.py: Fix monitor address typing python/machine.py: reorder __init__ python/machine.py: Don't modify state in _base_args() python/machine.py: Handle None events in events_wait python/machine.py: use qmp.command python/machine.py: Add _qmp access shim python/machine.py: fix _popen access python/qemu: make 'args' style arguments immutable iotests.py: Adjust HMP kwargs typing python/qemu: Add mypy type annotations
python/qemu/accel.py | 8 +- python/qemu/machine.py | 296 ++++++++++++++++++++-------------- python/qemu/qmp.py | 111 +++++++++---- python/qemu/qtest.py | 53 +++--- scripts/render_block_graph.py | 7 +- tests/qemu-iotests/iotests.py | 11 +- 6 files changed, 301 insertions(+), 185 deletions(-)
Signature · 1 line
2.21.3