Skip to content

python: add mypy support to python/qemu

John Snow qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest16 patches 4 repliesIn review
  2. v416 patches 3 repliesSuperseded
  3. v316 patches 17 repliesApplied
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v216 patches11 repliesSuperseded

v4 from the cover letter

- Rebased on "refactor shutdown" v4
- Fixed _qmp access for scripts that disable QMP

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16python/qmp.py: Define common typespython/qemu/qmp.py+18 -00 replies
2/16iotests.py: use qemu.qmp type aliasestests/qemu-iotests/iotests.py+3 -60 replies
3/16python/qmp.py: re-absorb MonitorResponseErrorpython/qemu/machine.py python/qemu/qmp.py scripts/render_block_graph.py+21 -180 replies
4/16python/qmp.py: Do not return None from cmd_objpython/qemu/qmp.py+5 -90 replies
5/16python/qmp.py: add casts to JSON deserializationpython/qemu/qmp.py+6 -20 replies
6/16python/qmp.py: add QMPProtocolErrorpython/qemu/qmp.py+10 -00 replies
7/16python/machine.py: Fix monitor address typingpython/qemu/machine.py+29 -160 replies
8/16python/machine.py: reorder __init__python/qemu/machine.py+17 -120 replies
9/16python/machine.py: Don't modify state in _base_args()python/qemu/machine.py python/qemu/qtest.py+18 -90 replies
10/16python/machine.py: Handle None events in events_waitpython/qemu/machine.py+20 -70 replies
11/16python/machine.py: use qmp.commandpython/qemu/machine.py+15 -110 replies
12/16python/machine.py: Add _qmp access shimpython/qemu/machine.py+13 -111 reply
13/16python/machine.py: fix _popen accesspython/qemu/machine.py+11 -51 reply
14/16python/qemu: make 'args' style arguments immutablepython/qemu/machine.py python/qemu/qtest.py+29 -170 replies
15/16iotests.py: Adjust HMP kwargs typingtests/qemu-iotests/iotests.py+1 -10 replies
16/16python/qemu: Add mypy type annotationspython/qemu/accel.py python/qemu/machine.py python/qemu/qmp.py +1 more+98 -741 reply

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by.

PatchKevin WolfPhilippe Mathieu-Daudé
1/16R-b
2/16R-b
3/16R-b R-b
4/16R-b
5/16R-b
6/16R-b R-b
7/16R-b
8/16R-b R-b
9/16R-b
10/16R-b
11/16R-b
12/16R-b
13/16R-b
14/16R-b
15/16R-b
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/16] python: add mypy support to python/qemu

Based-on: [email protected]

This series modifies the python/qemu library to comply with mypy --strict, pylint, and flake8.
This requires my "refactor shutdown" patch as a pre-requisite.

v5: (Things unchanged omitted)

003/16:[----] [-C] 'python/qmp.py: re-absorb MonitorResponseError' 009/16:[----] [-C] 'python/machine.py: Don't modify state in _base_args()' 012/16:[0004] [FC] 'python/machine.py: Add _qmp access shim' 013/16:[0002] [FC] 'python/machine.py: fix _popen access' 016/16:[0004] [FC] 'python/qemu: Add mypy type annotations'

-- Rebased on "refactor shutdown" v5
12: Dependent changes from more extensive shutdown() refactoring 13: Dependent changes; one less ._popen access.
16: Dependent changes; _post_shutdown return annotation fell down here.
wait annotation got bumped up to the previous series.

v4:
- Rebased on "refactor shutdown" v4
- Fixed _qmp access for scripts that disable QMP

v3:
005: Removed a cast, per Kevin Wolf's tip
010: Renamed with correct function name;
Rewrote docstring and added comments
016: Use SocketAddrT instead of Union[Tuple[str,str],str]

"v2":
- This version supports iotests 297
- Many patches merged by Phil are removed
- Replaces iotests.py type aliases with centralized ones (See patch 2)
- Imports etc are reworked to use the non-installable package layout instead. (Mostly important for patch 3)

Testing this out:
- You'll need Python3.6+
- I encourage you to use a virtual environment!
- You don't necessarily need these exact versions, but I didn't test the lower bounds, use older versions at your peril:
- pylint==2.5.0
- mypy=0.770
- flake8=3.7.8

Quoted 5 lines

cd ~/src/qemu/python/
flake8 qemu
mypy --strict qemu
cd qemu
pylint *.py

These should all 100% pass.

John Snow (16):
python/qmp.py: Define common types iotests.py: use qemu.qmp type aliases python/qmp.py: re-absorb MonitorResponseError python/qmp.py: Do not return None from cmd_obj python/qmp.py: add casts to JSON deserialization python/qmp.py: add QMPProtocolError python/machine.py: Fix monitor address typing python/machine.py: reorder __init__ python/machine.py: Don't modify state in _base_args() python/machine.py: Handle None events in events_wait python/machine.py: use qmp.command python/machine.py: Add _qmp access shim python/machine.py: fix _popen access python/qemu: make 'args' style arguments immutable iotests.py: Adjust HMP kwargs typing python/qemu: Add mypy type annotations

 python/qemu/accel.py          |   8 +-
 python/qemu/machine.py        | 296 ++++++++++++++++++++--------------
 python/qemu/qmp.py            | 111 +++++++++----
 python/qemu/qtest.py          |  53 +++---
 scripts/render_block_graph.py |   7 +-
 tests/qemu-iotests/iotests.py |  11 +-
 6 files changed, 301 insertions(+), 185 deletions(-)
Signature · 1 line
2.21.3