Skip to content

igc: PTP timestamping fixes

Andre Guedes intel-wired-lan 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6igc: Clean up rx timestamping logicdrivers/net/ethernet/intel/igc/igc.h drivers/net/ethernet/intel/igc/igc_defines.h drivers/net/ethernet/intel/igc/igc_main.c +2 more+5 -581 reply
2/6igc: Remove duplicate code in tx timestamp handlingdrivers/net/ethernet/intel/igc/igc_ptp.c+15 -191 reply
3/6igc: Check __IGC_PTP_TX_IN_PROGRESS instead of ptp_tx_skbdrivers/net/ethernet/intel/igc/igc_ptp.c+7 -91 reply
4/6igc: Remove UDP filter setup in PTP codedrivers/net/ethernet/intel/igc/igc_ptp.c+1 -501 reply
5/6igc: Refactor igc_ptp_set_timestamp_mode()drivers/net/ethernet/intel/igc/igc_ptp.c+53 -501 reply
6/6igc: Fix rx timestamp disablingdrivers/net/ethernet/intel/igc/igc_ptp.c+17 -371 reply

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchAaron Brown
1/6T-b
2/6T-b
3/6T-b
4/6T-b
5/6T-b
6/6T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Intel-wired-lan] [PATCH 0/6] igc: PTP timestamping fixes

Hi all,

This patch series provides some fixes and improvements to ptp timestamp handling in IGC driver.

IGC ptp implementation was based on IGB, but there are a few differences on how I225 handles rx timestamps that need to be considered. For example, I225 doesn't report rx timestamps via the TS bit rx descriptor + RXSTMPL/RXSTMPH registers mechanism. They are reported via the packet buffer only.

Apart from that, this patch series also fixes other issues like code duplication, dummy UDP filter configuration, and missing SRRCTL register clean up.

Regards,

Andre

Andre Guedes (6):
igc: Clean up rx timestamping logic
igc: Remove duplicate code in tx timestamp handling
igc: Check __IGC_PTP_TX_IN_PROGRESS instead of ptp_tx_skb
igc: Remove UDP filter setup in PTP code
igc: Refactor igc_ptp_set_timestamp_mode()
igc: Fix rx timestamp disabling

 drivers/net/ethernet/intel/igc/igc.h         |   3 -
 drivers/net/ethernet/intel/igc/igc_defines.h |   2 -
 drivers/net/ethernet/intel/igc/igc_main.c    |  12 +-
 drivers/net/ethernet/intel/igc/igc_ptp.c     | 256 +++++--------------
 drivers/net/ethernet/intel/igc/igc_regs.h    |   2 -
 5 files changed, 75 insertions(+), 200 deletions(-)
Signature · 1 line
2.26.2