nvme: fix reconnection stalls
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | nvme: check for NVME_CTRL_LIVE in nvme_report_ns_ids()drivers/ | +1 | 6 replies | |
| 2/2 | nvme: do not update multipath disk information if the controller is downdrivers/ | +1 | 0 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Anton Eidelman | Keith Busch |
|---|---|---|
| 1/2 | T-b | R-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] nvme: fix reconnection stalls
Hi all,
during testing we have come across namespaces not being available after reconnection. This is caused by (yet another) deadlock between reconnect and scanning; reconnection will wait for the scan workqueue to be flushed, but scanning cannot make progress if I/O is outstanding, as the I/O will only be completed _after_ reconnection completed.
The particular issue here is that nvme_revalidate_disk() might be several I/O to be sent; the first one (IDENTIFY NAMESPACE) will be terminated, but the subsequent ones are not.
These two patches fix this deadlock by checking the controller state before sending the I/O.
As usual, comments and reviews are welcome.
Hannes Reinecke (2):
nvme: check for NVME_CTRL_LIVE in nvme_report_ns_ids()
nvme: do not update multipath disk information if the controller is
down
drivers/nvme/host/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 7 lines
2.16.4 _______________________________________________ linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme