Skip to content

iotests: Dump QCOW2 dirty bitmaps metadata

Vladimir Sementsov-Ogievskiy qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest13 patches 9 repliesIn review
  2. v412 patches 25 repliesSuperseded

Changes in v5 from the cover letter · 18 lines

01: - typo in commit message
- fix over-79 lines
02: new, specify GPL license
03: specify GPL license
04-06: add Andrey's r-b
07: - grammar in commit message
- add Andrey's r-b
08: - add copyright
- note u8 and u16 in a comment
- add doc for __init__ of Qcow2Struct
- add Andrey's r-b
09-10: add Andrey's r-b
11: - note about current fd position in __init__ doc of
QcowHeaderExtension
- add Andrey's r-b
12: - keep magic in hex
- use lower-case for magic constants
13: add Andrey's r-b

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13qcow2.py: python style fixestests/qemu-iotests/qcow2.py+56 -391 reply
2/13qcow2.py: add licensing blurbtests/qemu-iotests/qcow2.py+16 -01 reply
3/13qcow2.py: move qcow2 format classes to separate moduletests/qemu-iotests/qcow2.py tests/qemu-iotests/qcow2_format.py+177 -1561 reply
4/13qcow2_format.py: drop new line printing at end of dump()tests/qemu-iotests/qcow2.py tests/qemu-iotests/qcow2_format.py+1 -10 replies
5/13qcow2_format.py: use tuples instead of lists for fieldstests/qemu-iotests/qcow2_format.py+20 -200 replies
6/13qcow2_format.py: use modern string formattingtests/qemu-iotests/qcow2_format.py+27 -270 replies
7/13qcow2_format.py: use strings to specify c-type of struct fieldstests/qemu-iotests/qcow2_format.py+28 -220 replies
8/13qcow2_format.py: separate generic functionality of structure classestests/qemu-iotests/qcow2_format.py+66 -351 reply
9/13qcow2_format.py: add field-formatting classtests/qemu-iotests/qcow2_format.py+25 -100 replies
10/13qcow2_format.py: QcowHeaderExtension: add dump methodtests/qemu-iotests/qcow2_format.py+12 -100 replies
11/13qcow2_format: refactor QcowHeaderExtension as a subclass of Qcow2Structtests/qemu-iotests/qcow2_format.py+37 -160 replies
12/13qcow2: QcowHeaderExtension print names for extension magicstests/qemu-iotests/031.out tests/qemu-iotests/036.out tests/qemu-iotests/061.out +1 more+36 -213 replies
13/13qcow2_format.py: dump bitmaps header extensiontests/qemu-iotests/291 tests/qemu-iotests/291.out tests/qemu-iotests/qcow2_format.py+70 -92 replies

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchAndrey ShinkevichEric Blake
1/13R-b T-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13R-b
9/13R-b
10/13R-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/13] iotests: Dump QCOW2 dirty bitmaps metadata

Hi all!

Here is my suggestion to substitute only first three patches :) of Andrey's [PATCH v3 0/6] iotests: Dump QCOW2 dirty bitmaps metadata

v5:
01: - typo in commit message
- fix over-79 lines
02: new, specify GPL license
03: specify GPL license
04-06: add Andrey's r-b
07: - grammar in commit message
- add Andrey's r-b
08: - add copyright
- note u8 and u16 in a comment
- add doc for __init__ of Qcow2Struct
- add Andrey's r-b
09-10: add Andrey's r-b
11: - note about current fd position in __init__ doc of
QcowHeaderExtension
- add Andrey's r-b
12: - keep magic in hex
- use lower-case for magic constants
13: add Andrey's r-b

Tags up-refactor-qcow2.py-v4 and up-refactor-qcow2.py-v4 may be found
here: https://src.openvz.org/users/vsementsov/repos/qemu/browse
(git remote: https://src.openvz.org/scm/~vsementsov/qemu.git)

Plan for continuation:

- add type hints
- support compression_type field
- dump more about bitmaps

Vladimir Sementsov-Ogievskiy (13):
qcow2.py: python style fixes
qcow2.py: add licensing blurb
qcow2.py: move qcow2 format classes to separate module qcow2_format.py: drop new line printing at end of dump() qcow2_format.py: use tuples instead of lists for fields qcow2_format.py: use modern string formatting qcow2_format.py: use strings to specify c-type of struct fields qcow2_format.py: separate generic functionality of structure classes qcow2_format.py: add field-formatting class qcow2_format.py: QcowHeaderExtension: add dump method
qcow2_format: refactor QcowHeaderExtension as a subclass of
Qcow2Struct
qcow2: QcowHeaderExtension print names for extension magics qcow2_format.py: dump bitmaps header extension

 tests/qemu-iotests/031.out         |  22 +--
 tests/qemu-iotests/036.out         |   4 +-
 tests/qemu-iotests/061.out         |  14 +-
 tests/qemu-iotests/291             |   4 +
 tests/qemu-iotests/291.out         |  33 ++++
 tests/qemu-iotests/qcow2.py        | 218 +++++-----------------
 tests/qemu-iotests/qcow2_format.py | 286 +++++++++++++++++++++++++++++
 7 files changed, 393 insertions(+), 188 deletions(-)
 create mode 100644 tests/qemu-iotests/qcow2_format.py
Signature · 1 line
2.21.0