Skip to content

bfq: Two fixes and a cleanup for sequential readers

Jan Kara linux-block stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3bfq: Avoid false bfq queue mergingblock/bfq-iosched.c+1 -04 replies
1/3bfq: Avoid false bfq queue mergingblock/bfq-iosched.c+1 -00 replies
2/3bfq: Use 'ttime' local variableblock/bfq-iosched.c+1 -11 reply
2/3bfq: Use 'ttime' local variableblock/bfq-iosched.c+1 -10 replies
3/3bfq: Use only idle IO periods for think time calculationsblock/bfq-iosched.c+10 -28 replies
3/3bfq: Use only idle IO periods for think time calculationsblock/bfq-iosched.c+9 -10 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchPaolo Valente
1/3A-b A-b A-b
1/3A-b A-b A-b
2/3A-b A-b
2/3A-b A-b
3/3A-b A-b
3/3A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] bfq: Two fixes and a cleanup for sequential readers

Hello,

this patch series contains one tiny cleanup and two relatively simple fixes for BFQ I've uncovered when analyzing behavior of four parallel sequential readers on one machine. The fio jobfile is like:

[global]
direct=0
ioengine=sync
invalidate=1
size=16g
rw=read
bs=4k

[reader]
numjobs=4
directory=/mnt

The first patch fixes a problem due to which the four bfq queues were getting merged without a reason. The third patch fixes a problem where we were unfairly raising bfq queue think time (leading to clearing of short_ttime and subsequent reduction in throughput).

What do people think about these?

Honza