Skip to content

add basic driver support for broadcom NS3 soc

Tom Rini u-boot 1 version New

Get series with b4
b4 am 20200605150555.GG32287@bill-the-cat

Versions newest first

  1. v1 Latest0 of 15 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 15 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 00/15] add basic driver support for broadcom NS3 soc
Quoted 102 lines · Soeren Moch
Quoted 101 lines · Tom Rini
Quoted 99 lines · Simon Glass

Hi Rayagonda,

Quoted 76 lines · Rayagonda Kokatanur

Hi Simon,

Quoted 51 lines · Simon Glass

Hi Rayagonda,

Quoted 37 lines · Rayagonda Kokatanur

Hi Thomas,

Quoted 33 lines · Thomas Fitzsimmons
Quoted 30 lines · Rayagonda Kokatanur
Quoted 28 lines · Tom Rini
Quoted 21 lines · Rayagonda Kokatanur

Hi Tom,

Quoted 6 lines · Tom Rini
Quoted 3 lines · Rayagonda Kokatanur

This is the second patch set series prepared on top of the first patch set ("add initial support for broadcom NS3 soc").

Quoted 10 lines

Review

Quoted 6 lines

This patch set will add following,

(quoted diff) +0 -4
-dt nodes and defconfig options for basic device like pinctrl,
 gpio, mmc, qspi, wdt, i2c and pcie.
-start wdt service
-Enable GPT commands
-Enable EXT4 and FAT fs support

All of the dts changes not in a -u-boot.dtsi file either come from mainline Linux or at least linux-next and have had some level upstream review, right? Thanks!

Quoted 2 lines

Yes. All the DTS changes are merged in the Linux and are available at arch/arm64/boot/dts/broadcom/stingray/

Great. Please reference the release you're taking these from as that will make future resyncs easier. Thanks!

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

It's Linux v5.6.

What's the relationship between e.g., bcm958742t.dts and ns3.dts? I looked at the mainline Linux device trees and I couldn't easily see the correspondence. Will the renaming complicate synchronization?

Do we need to maintain the same dt file between linux and uboot ? Also in uboot we don't enable all devices, how do we handle this ?

Quoted 7 lines

If there is no U-Boot driver for a particular node then it will be ignored. It is easier to keep them in sync if they are the same in U-Boot and Linux.

Quoted 1 line

Please let me know.

That is implied by your question above :-)

NS3 board is derivative of the existing bcm95874t board (arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dt)
Hence we have different dt for NS3 in Linux but it is not yet upstremed.

I compared the dt file size between uboot and Linux. Uboot dt size = 9K
Linux dt size = 41K (32K extra)

In uboot we have 8MB non-volatile SPI flash memory.
Out of 8MB, 1.5MB is allocated to fip.bin image and remaining 6.5MB space is allocated to other components
like nitor/bnxt firmware image, DDR shmoo value and for backup image.

Quoted 8 lines

uboot.bin is part of the fip.bin image. If we pull Linux dt files this will use extra 33K memory of allocated 1.5MB.
This increase in 33K will reduce total memory availability for u-boot and other features (like ARM trusted firmware, Op-TEE OS) development in future.
Hence we anticipate qpsi memory shortage going ahead for new features.

So please let me know your view on maintaining different dt files in uboot.

Sounds like you have plenty of memory, actually. Is U-Boot the first thing to load?

I think it is important to use the same filename and have the same DT contents where they are present in U-Boot. But if you want to leave out nodes, etc., that seems OK to me. It should be easy enough to meld in the updates later.

I wonder if we should add a way to drop unused nodes for U-Boot proper, like we do for SPL?

Quoted 6 lines
Quoted 3 lines

We have that for a little while now, OF_DTB_PROPS_REMOVE, from trying to trim things down for tbs2910.

For tbs2910 we remove some properties, not whole nodes, from the dtb. Is it possible to also remove complete nodes? This would help even more for size reduction, I think.

Ah, that I think not. Another idea to keep in mind for the dtoc enhancements perhaps? There is very much a use case of having a dtb (or set of dtbs) and a U-Boot (full or SPL) and not needing/wanting to pass our DTB on to the OS so both discarding things from the DTB and from U-Boot based on this knowledge would be great.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200605/a3f0ac48/attachment.sig>