Skip to content

roc-rk3399-pc: Custom SPL init

Jagan Teki linux-rockchip u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest5 patches 0 repliesNew

Changes in v3 from the cover letter

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5rk3399: spl: Add rk_spl_board_init as __weakarch/arm/mach-rockchip/rk3399/rk3399.c+8 -10 replies
2/5rk3399: spl: Print SPL banner after relocationarch/arm/mach-rockchip/rk3399/rk3399.c arch/arm/mach-rockchip/spl.c+2 -10 replies
3/5roc-rk3399-pc: Move leds setup in SPLarch/arm/mach-rockchip/tpl.c board/firefly/roc-pc-rk3399/Makefile board/firefly/roc-pc-rk3399/roc-pc-rk3399.c +3 more+29 -300 replies
4/5rockchip: Separate the reset cause from display cpuinfoarch/arm/include/asm/arch-rockchip/cru.h arch/arm/mach-rockchip/Makefile arch/arm/mach-rockchip/cpu-info.c+18 -90 replies
5/5roc-rk3399-pc: Set LED only during POR and pwr_key=yboard/firefly/roc-pc-rk3399/spl.c configs/roc-pc-mezzanine-rk3399_defconfig configs/roc-pc-rk3399_defconfig+40 -30 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchSuniel Mahesh
1/5T-b
2/5T-b
3/5T-b
4/5T-b
5/5T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] roc-rk3399-pc: Custom SPL init

This series supports custom initialization code required for roc-rk3399-pc board on SPL stage. I have marked it as v3, since we have tried this before on this series[1].

Now this series is well mature code handling to add custom spl_board_init code parts.

roc-rk3399-pc would require custom leds initialization based on user intervention of the power key. This code handles the user intervention via SPI environment variable. If someone or production systems wants this feature then 'pwr_key' has to be set otherwise it is normal like other rk3399 boards in Mainline.

Changes for v3:
- support leds on SPL
- support env 'pwr_key'

[1] https://patchwork.ozlabs.org/project/uboot/patch/20200319101251.7354-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org/

Any inputs?
Jagan.

Jagan Teki (5):
rk3399: spl: Add rk_spl_board_init as __weak
rk3399: spl: Print SPL banner after relocation
roc-rk3399-pc: Move leds setup in SPL
rockchip: Separate the reset cause from display cpuinfo
roc-rk3399-pc: Set LED only during POR and pwr_key=y

 arch/arm/include/asm/arch-rockchip/cru.h    |  2 +
 arch/arm/mach-rockchip/Makefile             |  5 +-
 arch/arm/mach-rockchip/cpu-info.c           | 20 +++++---
 arch/arm/mach-rockchip/rk3399/rk3399.c      | 11 +++-
 arch/arm/mach-rockchip/spl.c                |  1 -
 arch/arm/mach-rockchip/tpl.c                |  7 ---
 board/firefly/roc-pc-rk3399/Makefile        |  4 ++
 board/firefly/roc-pc-rk3399/roc-pc-rk3399.c | 21 --------
 board/firefly/roc-pc-rk3399/spl.c           | 56 +++++++++++++++++++++
 configs/roc-pc-mezzanine-rk3399_defconfig   |  6 ++-
 configs/roc-pc-rk3399_defconfig             |  6 ++-
 11 files changed, 96 insertions(+), 43 deletions(-)
 create mode 100644 board/firefly/roc-pc-rk3399/spl.c
Signature · 1 line
2.20.1