Skip to content

net: dsa: qca8k: Improve SGMII interface handling

Jonathan McDowell linux-devicetree lkml netdev oe-kbuild oe-kbuild-all 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 1 replyIn review
  2. v4 RFC2 patches 3 repliesSuperseded
  3. v3 RFC0 of 2 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v2 RFC1 patch2 repliesSuperseded

Changes in v5 from the cover letter

- Move spelling fix to separate patch
- Use ds directly rather than ds->priv

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: dsa: qca8k: Switch to PHYLINK instead of PHYLIBdrivers/net/dsa/qca8k.c+210 -960 replies
2/3net: dsa: qca8k: Improve SGMII interface handlingdrivers/net/dsa/qca8k.c drivers/net/dsa/qca8k.h+45 -10 replies
3/3net: dsa: qca8k: Minor comment spelling fixdrivers/net/dsa/qca8k.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH net-next v5 0/3] net: dsa: qca8k: Improve SGMII interface handling

This 3 patch series migrates the qca8k switch driver over to PHYLINK, and then adds the SGMII clean-ups (i.e. the missing initialisation) on top of that as a second patch. The final patch is a simple spelling fix in a comment.

As before, tested with a device where the CPU connection is RGMII (i.e. the common current use case) + one where the CPU connection is SGMII. I don't have any devices where the SGMII interface is brought out to something other than the CPU.

v5:
- Move spelling fix to separate patch
- Use ds directly rather than ds->priv
v4:
- Enable pcs_poll so we keep phylink updated when doing in-band negotiation
- Explicitly check for PHY_INTERFACE_MODE_1000BASEX when setting SGMII port mode.
- Address Vladimir's review comments
v3:
- Move phylink changes to separate patch
- Address rmk review comments
v2:
- Switch to phylink
- Avoid need for device tree configuration options

Jonathan McDowell (3):
net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB
net: dsa: qca8k: Improve SGMII interface handling
net: dsa: qca8k: Minor comment spelling fix

 drivers/net/dsa/qca8k.c | 341 ++++++++++++++++++++++++++++------------
 drivers/net/dsa/qca8k.h |  13 ++
 2 files changed, 256 insertions(+), 98 deletions(-)
Signature · 1 line
2.20.1