Skip to content

Put safeguards around Leave & Attach calls

Inga Stotland linux-bluetooth 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 6 repliesIn review
  2. v24 patches 0 repliesSuperseded
  3. v14 patches 1 replySuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5mesh: Delete unused functionmesh/node.c mesh/node.h+0 -60 replies
2/5mesh: Make "Busy" and "InProgress" to be distinct errorsdoc/mesh-api.txt mesh/dbus.c mesh/error.h +1 more+9 -80 replies
3/5mesh: Add destroy callback to dbus_send_with_timeout()mesh/dbus.c mesh/dbus.h mesh/mesh.c+14 -60 replies
4/5mesh: Add timeout to GetManagedObjects callmesh/node.c+20 -230 replies
5/5mesh: Add "node is busy" check for Leave() & Attach()doc/mesh-api.txt mesh/mesh.c mesh/node.c +2 more+34 -35 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH BlueZ v3 0/5] Put safeguards around Leave & Attach calls

This set of patches addresses the situation when an application calls Leave() or Attach() methods on a node that has another incomplete method call on Network interface associated with it.

The simple solution is to return error in response to Leave() method if an application still owes the daemon either a reply to GetManagedObjects request in case of Attach() or a reply to JoinComplete() in case of Join(), Create() or Import()

Similarly, a "Busy" error is returned in response to Attach() method if an application still owes the daemon a reply to JoinComplete() in case of pending Join(), Create() or Import()

Inga Stotland (5):
mesh: Delete unused function
mesh: Make "Busy" and "InProgress" to be distinct errors
mesh: Add destroy callback to dbus_send_with_timeout()
mesh: Add timeout to GetManagedObjects call
mesh: Add "node is busy" check for Leave() & Attach()

 doc/mesh-api.txt |  5 +++-
 mesh/dbus.c      | 10 +++++++-
 mesh/dbus.h      |  1 +
 mesh/error.h     |  1 +
 mesh/manager.c   | 11 ++++-----
 mesh/mesh.c      | 22 +++++++++++------
 mesh/node.c      | 63 +++++++++++++++++++++++++++++-------------------
 mesh/node.h      |  2 +-
 test/test-mesh   |  2 --
 9 files changed, 74 insertions(+), 43 deletions(-)
Signature · 1 line
2.26.2