Skip to content

hw/block/nvme: fix assert on invalid irq vector

Klaus Jensen qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 1 patch 8 repliesIn review

Patches in v1 No applies recorded yet

The patch the cover letter announces is not in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] hw/block/nvme: fix assert on invalid irq vector

From: Klaus Jensen <[email protected]>

I goofed up with commit c09794fe40e3 ("hw/block/nvme: allow use of any valid msix vector").

This fixes the goof by adding a new msix_qsize parameter. As a nice side-effect this allows a device with less interrupt vectors available than supported queues. Also, improve the error handling in nvme_init_pci().

Kevin, please consider picking this up for the block branch when reviewed.

Cc Keith Busch <[email protected]>
Cc Max Reitz <[email protected]>
Cc Kevin Wolf <[email protected]>
Cc Klaus Jensen <[email protected]>
Cc Javier Gonzalez <[email protected]>
Cc Maxim Levitsky <[email protected]>
Cc Philippe Mathieu-Daudé <[email protected]>

Klaus Jensen (2):
hw/block/nvme: add msix_qsize parameter hw/block/nvme: verify msix_init_exclusive_bar() return value

 hw/block/nvme.c | 28 ++++++++++++++++++++++------
 hw/block/nvme.h |  1 +
 2 files changed, 23 insertions(+), 6 deletions(-)
Signature · 1 line
2.27.0