PCI: Align return value of pcie capability accessors with other accessors
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | PCI: Convert PCIBIOS_ error codes to non-PCI generic error codesdrivers/ | +2 | 0 replies | |
| 2/8 | PCI: Convert PCIBIOS_ error codes to non-PCI generic error codesdrivers/ | +1 | 0 replies | |
| 3/8 | PCI: Convert PCIBIOS_ error codes to non-PCI generic error codesdrivers/ | +12 | 1 reply | |
| 4/8 | PCI: Convert PCIBIOS_ error codes to non-PCI generic error codesdrivers/ | +8 | 0 replies | |
| 5/8 | PCI: Convert PCIBIOS_ error codes to non-PCI generic error codesdrivers/ | +5 | 0 replies | |
| 6/8 | PCI: Convert PCIBIOS_ error codes to non-PCI generic error codesdrivers/ | +5 | 1 reply | |
| 7/8 | PCI: Convert PCIBIOS_ error codes to non-PCI generic error codesdrivers/ | +5 | 1 reply | |
| 8/8 | PCI: Align return value of pcie capability accessors with other accessorsdrivers/ | +4 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/8] PCI: Align return value of pcie capability accessors with other accessors
From: Bolarinwa Olayemi Saheed <[email protected]>
PATCH 1 to 7:
PCIBIOS_ error codes have positive values and they are passed down the call heirarchy from accessors. For functions which are meant to return only a negative value on failure, passing on this value is a bug.
To mitigate this, call pcibios_err_to_errno() before passing on return value from pcie capability accessors call heirarchy. This function converts any positive PCIBIOS_ error codes to negative non-PCI generic error values.
PATCH 8:
The pcie capability accessors can return 0, -EINVAL, or any PCIBIOS_ error code. The pci accessor on the other hand can only return 0 or any PCIBIOS_ error code.This inconsistency among these accessor makes it harder for callers to check for errors.
Return PCIBIOS_BAD_REGISTER_NUMBER instead of -EINVAL in all pcie capability accessors.
Bolarinwa Olayemi Saheed (8):
PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
PCI: Align return value of pcie capability accessors with other
accessors
drivers/dma/ioat/init.c | 4 ++-- drivers/infiniband/hw/hfi1/pcie.c | 18 +++++++++++++----- drivers/pci/access.c | 8 ++++---- drivers/pci/pci.c | 10 ++++++++-- drivers/pci/pcie/aer.c | 12 ++++++++++-- drivers/scsi/smartpqi/smartpqi_init.c | 6 +++++- 6 files changed, 42 insertions(+), 16 deletions(-)
Signature · 1 line
2.18.2