Skip to content

qede: SR-IOV PF driver support

Manish Chopra dpdk-dev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 4 repliesIn review
  2. v56 patches 1 replySuperseded
  3. v46 patches 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v36 patches6 repliesSuperseded
v27 patches18 repliesSuperseded
v16 patches6 repliesSuperseded

Changes in v6 from the cover letter

=======

* Re-based it on latest dpdk-next-net-mrvl.git (driver/net/qede/Makefile change removed from patch #3, file no longer exist)
* Added Reviewed-by tag and renamed rte_pci_find_next_ext_capability to rte_pci_find_ext_capability as per comment from Nithin Kumar Dabilpuram

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drivers: add generic API to find PCI extended capdrivers/bus/pci/pci_common.c drivers/bus/pci/rte_bus_pci.h drivers/bus/pci/rte_bus_pci_version.map +4 more+94 -1064 replies
2/6net/qede: define PCI config space specific osalsdrivers/net/qede/base/bcm_osal.h drivers/net/qede/base/ecore.h drivers/net/qede/base/ecore_dev.c +4 more+53 -240 replies
3/6net/qede: configure VFs on hardwaredrivers/net/qede/meson.build drivers/net/qede/qede_ethdev.c drivers/net/qede/qede_ethdev.h +4 more+99 -00 replies
4/6net/qede: add infrastructure support for VF loaddrivers/net/qede/base/bcm_osal.c drivers/net/qede/base/bcm_osal.h drivers/net/qede/base/ecore.h +5 more+121 -60 replies
5/6net/qede: initialize VF MAC and linkdrivers/net/qede/qede_ethdev.c drivers/net/qede/qede_main.c drivers/net/qede/qede_sriov.c +1 more+94 -20 replies
6/6net/qede: add VF FLR supportdoc/guides/nics/features/qede.ini doc/guides/nics/qede.rst drivers/net/qede/base/bcm_osal.c +2 more+28 -70 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchGaetan RivetJerin Jacob
1/6R-b R-b
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [dpdk-dev] [PATCH v6 0/6] qede: SR-IOV PF driver support

Hi,

This series adds SR-IOV PF pmd driver support to have VF pmd driver work over PF pmd driver instances in order to run the adapter completely under DPDK environment for one of the use cases like ovs-dpdk.

This is very initial bring-up with following testing covered -

* Enable/Disable SR-IOV VFs through igb_uio sysfs hook.
* Load VFs, run fastpath, teardown VFs in hypervisor and guest VM.
* VF FLR flow (in case of VF PCI passthrough to the guest VM)
* Bulletin mechanism tested to communicate link changes to the VFs.

Note that this series is intended for upcoming DPDK release (20.11) Please consider applying this series to dpdk-next-net-mrvl.git

V5->V6:
=======

* Re-based it on latest dpdk-next-net-mrvl.git (driver/net/qede/Makefile change removed from patch #3, file no longer exist)
* Added Reviewed-by tag and renamed rte_pci_find_next_ext_capability to rte_pci_find_ext_capability as per comment from Nithin Kumar Dabilpuram

V4->V5:
=======

* drivers/raw/ifpga was escaped to compile, test-robot reported below build failure which is fixed within patch #1 in this series.

'drivers/drivers@@tmp_rte_rawdev_ifpga@sta/raw_ifpga_ifpga_rawdev.c.o' -c ../drivers/raw/ifpga/ifpga_rawdev.c ../drivers/raw/ifpga/ifpga_rawdev.c: In function ‘ifpga_pci_find_next_ext_capability’:
../drivers/raw/ifpga/ifpga_rawdev.c:166:34: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
if (RTE_PCI_EXT_CAP_ID(header) == cap && pos != start)

                                  ^~

cc1: all warnings being treated as errors

V3->V4:
=======

* Fixed meson/ninja build failure for AMD arch.
* Incorporated cosmetic changes pointed by Gaetan.

V2->V3:
=======

* Instead of adding complete pci_regs.h file from linux, define handful PCI symbols (prefixed with RTE_) in dpdk which are required to implement generic rte_pci_find_next_ext_capability() API (patch #1) and to enable various other qede driver's OSAL_* defines (patch #2) (essentially, removed the patch #1 in v2)

* Fixed meson/ninja compilation issues reported

* Incorporated comments by Gaetan for rte_pci_find_next_ext_capability()

V1->V2: (Incorporated comments from Jerin Jacob)
================================================

* Added rte_pci_regs.h file (copy of linux/pci_regs.h) under lib/librte_pci to remove the dependency of dpdk on user headers

* Added generic API to find PCI extended capability and use that in the drivers, removed individual functions implemented by the drivers

Thanks,
Manish

Manish Chopra (6):
drivers: add generic API to find PCI extended cap net/qede: define PCI config space specific osals net/qede: configure VFs on hardware net/qede: add infrastructure support for VF load net/qede: initialize VF MAC and link net/qede: add VF FLR support

 doc/guides/nics/features/qede.ini          |   1 +
 doc/guides/nics/qede.rst                   |   7 +-
 drivers/bus/pci/pci_common.c               |  43 ++++
 drivers/bus/pci/rte_bus_pci.h              |  19 ++
 drivers/bus/pci/rte_bus_pci_version.map    |   6 +
 drivers/net/ice/ice_ethdev.c               |  51 +----
 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |  48 +----
 drivers/net/qede/base/bcm_osal.c           |  31 +++
 drivers/net/qede/base/bcm_osal.h           |  29 ++-
 drivers/net/qede/base/ecore.h              |   7 +
 drivers/net/qede/base/ecore_dev.c          |   6 +-
 drivers/net/qede/base/ecore_iov_api.h      |   3 +
 drivers/net/qede/base/ecore_sriov.c        |  28 +--
 drivers/net/qede/base/meson.build          |   2 +-
 drivers/net/qede/meson.build               |   1 +
 drivers/net/qede/qede_ethdev.c             |  37 +++-
 drivers/net/qede/qede_ethdev.h             |   1 +
 drivers/net/qede/qede_if.h                 |   1 +
 drivers/net/qede/qede_main.c               |  12 +-
 drivers/net/qede/qede_sriov.c              | 219 +++++++++++++++++++++
 drivers/net/qede/qede_sriov.h              |  22 +++
 drivers/raw/ifpga/ifpga_rawdev.c           |  17 +-
 lib/librte_pci/rte_pci.h                   |  35 ++++
 23 files changed, 485 insertions(+), 141 deletions(-)
 create mode 100644 drivers/net/qede/qede_sriov.c
 create mode 100644 drivers/net/qede/qede_sriov.h
Signature · 1 line
2.17.1