Skip to content

kmod/umh: a few fixes

Luis R. Rodriguez bridge keyrings linux-fsdevel linux-nfs linux-s390 linux-security-module lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 37 repliesIn review 3 of 5 applied

Patches in v1 3 of 5 applied

#Subject and filesSizeRepliesApplied
1/5selftests: kmod: Use variable NAME in kmod_test_0001()tools/testing/selftests/kmod/kmod.sh+2 -20 repliesApplied
2/5kmod: Remove redundant "be an" in the commentkernel/kmod.c+2 -30 repliesApplied
3/5test_kmod: Avoid potential double free in trigger_config_run_type()lib/test_kmod.c+1 -10 repliesApplied
4/5umh: fix processed error when UMH_WAIT_PROC is useddrivers/block/drbd/drbd_nl.c fs/nfsd/nfs4recover.c include/linux/sched/task.h +3 more+27 -2434 replies
5/5selftests: simplify kmod failure valuetools/testing/selftests/kmod/kmod.sh+39 -70 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchLuis Chamberlain
1/5A-b
2/5A-b
3/5A-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] kmod/umh: a few fixes

From: Luis Chamberlain <[email protected]>

Tiezhu Yang had sent out a patch set with a slew of kmod selftest fixes, and one patch which modified kmod to return 254 when a module was not found. This opened up pandora's box about why that was being used for and low and behold its because when UMH_WAIT_PROC is used we call a kernel_wait4() call but have never unwrapped the error code. The commit log for that fix details the rationale for the approach taken. I'd appreciate some review on that, in particular nfs folks as it seems a case was never really hit before.

This goes boot tested, selftested with kmod, and 0-day gives its build blessings.

Luis Chamberlain (2):
umh: fix processed error when UMH_WAIT_PROC is used
selftests: simplify kmod failure value

Tiezhu Yang (3):
selftests: kmod: Use variable NAME in kmod_test_0001()
kmod: Remove redundant "be an" in the comment
test_kmod: Avoid potential double free in trigger_config_run_type()

 drivers/block/drbd/drbd_nl.c         | 20 +++++------
 fs/nfsd/nfs4recover.c                |  2 +-
 include/linux/sched/task.h           | 13 ++++++++
 kernel/kmod.c                        |  5 ++-
 kernel/umh.c                         |  4 +--
 lib/test_kmod.c                      |  2 +-
 net/bridge/br_stp_if.c               | 10 ++----
 security/keys/request_key.c          |  2 +-
 tools/testing/selftests/kmod/kmod.sh | 50 +++++++++++++++++++++++-----
 9 files changed, 71 insertions(+), 37 deletions(-)
Signature · 1 line
2.26.2