Skip to content

perf parse-events: enable more flex/bison warnings

Ian Rogers lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 4 repliesIn review
  2. v110 patches 5 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10perf parse-events: Use automatic variable for flex inputtools/perf/util/Build+3 -30 replies
2/10perf parse-events: Use automatic variable for yacc inputtools/perf/util/Build+3 -30 replies
3/10perf pmu: Add bison debug build flagtools/perf/util/Build+1 -10 replies
4/10perf pmu: Add flex debug build flagtools/perf/util/Build+1 -10 replies
5/10perf parse-events: Declare flex header file outputtools/perf/util/Build+9 -60 replies
6/10perf parse-events: Declare bison header file outputtools/perf/util/Build+9 -60 replies
7/10perf parse-events: Disable a subset of flex warningstools/perf/util/Build+9 -30 replies
8/10perf expr: Avoid implicit lex function declarationtools/perf/util/Build tools/perf/util/expr.y+4 -00 replies
9/10perf parse-events: Avoid implicit lex function declarationtools/perf/util/Build tools/perf/util/parse-events.y+3 -00 replies
10/10perf parse-events: Disable a subset of bison warningstools/perf/util/Build+11 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/10] perf parse-events: enable more flex/bison warnings

All C compiler warnings are disabled are disabled by -w. This change removes the -w from flex and bison targets. To avoid implicit declarations header files are declared as targets and included.

Tested with GCC 9.3.0 and clang 9.0.1.

v2. predicates disabling the warnings on more recent bison and flex
versions (3.5.3 and 2.6.4 respectively). An alternative would be to disabled a large number of warnings to cover the warnings generated in older distributions:

  flex_flags := -Wno-switch-enum -Wno-switch-default -Wno-unused-function \
    -Wno-redundant-decls -Wno-sign-compare -Wno-unused-parameter \
    -Wno-missing-prototypes -Wno-misleading-indentation

bison_flags := -DYYENABLE_NLS=0 -Wno-unused-parameter -Wno-nested-externs \
-Wno-implicit-function-declaration -Wno-switch-enum

Previously posted as a single change:
https://lore.kernel.org/lkml/[email protected]/

Ian Rogers (10):
perf parse-events: Use automatic variable for flex input perf parse-events: Use automatic variable for yacc input perf pmu: Add bison debug build flag
perf pmu: Add flex debug build flag
perf parse-events: Declare flex header file output perf parse-events: Declare bison header file output perf parse-events: Disable a subset of flex warnings perf expr: Avoid implicit lex function declaration perf parse-events: Avoid implicit lex function declaration perf parse-events: Disable a subset of bison warnings

 tools/perf/util/Build          | 62 +++++++++++++++++++++++-----------
 tools/perf/util/expr.y         |  2 ++
 tools/perf/util/parse-events.y |  1 +
 3 files changed, 46 insertions(+), 19 deletions(-)
Signature · 1 line
2.27.0.111.gc72c7da667-goog