Skip to content

ast cleanups

Thomas Zimmermann dri-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyIn review
  2. v13 patches 13 repliesSuperseded

Changes in v2 from the cover letter

* remove device tests from ast_pm_freeze() (Daniel)
* convert WARN_*() (Sam)
* typo fixes

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/ast: Remove unused code paths for AST 1180drivers/gpu/drm/ast/ast_drv.c drivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_main.c +2 more+43 -690 replies
2/4drm/ast: Remove test for device from ast_pm_freeze()drivers/gpu/drm/ast/ast_drv.c+0 -31 reply
3/4drm/ast: Upcast from DRM device to ast structure via to_ast_private()drivers/gpu/drm/ast/ast_dp501.c drivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_main.c +2 more+50 -460 replies
4/4drm/ast: Use per-device logging macrosdrivers/gpu/drm/ast/ast_main.c drivers/gpu/drm/ast/ast_mode.c drivers/gpu/drm/ast/ast_post.c +1 more+34 -300 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDaniel VetterEmil VelikovSam Ravnborg
1/4R-b R-b
2/4A-b
3/4R-b R-b A-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/4] ast cleanups

Ast still has to be converted to managed initialization, and embed the DRM device in the ast structure. In preparation of these changes, add some cleanups to the driver.

Tested on ast HW.

v2:
* remove device tests from ast_pm_freeze() (Daniel)
* convert WARN_*() (Sam)
* typo fixes

Thomas Zimmermann (4):
drm/ast: Remove unused code paths for AST 1180
drm/ast: Remove test for device from ast_pm_freeze() drm/ast: Upcast from DRM device to ast structure via to_ast_private() drm/ast: Use per-device logging macros

 drivers/gpu/drm/ast/ast_dp501.c |  24 +++----
 drivers/gpu/drm/ast/ast_drv.c   |   4 --
 drivers/gpu/drm/ast/ast_drv.h   |   7 +-
 drivers/gpu/drm/ast/ast_main.c  | 115 +++++++++++++++-----------------
 drivers/gpu/drm/ast/ast_mode.c  |  73 ++++++++++----------
 drivers/gpu/drm/ast/ast_post.c  |  28 ++++----
 drivers/gpu/drm/ast/ast_ttm.c   |   2 +-
 7 files changed, 116 insertions(+), 137 deletions(-)

--
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel