Skip to content

remove extended cede offline mode and bogus topology update code

Nathan Lynch linuxppc-dev 1 version Applied

Status from this message: Applied to powerpc/next.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 13 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/18powerpc/pseries: remove cede offline state for CPUsDocumentation/core-api/cpu_hotplug.rst arch/powerpc/platforms/pseries/hotplug-cpu.c arch/powerpc/platforms/pseries/offline_states.h +2 more+15 -2290 replies
2/18powerpc/rtas: don't online CPUs for partition suspendarch/powerpc/include/asm/rtas.h arch/powerpc/kernel/rtas.c arch/powerpc/platforms/pseries/suspend.c+3 -1430 replies
3/18powerpc/numa: remove ability to enable topology updatesarch/powerpc/mm/numa.c+1 -701 reply
4/18powerpc/numa: remove unreachable topology update codearch/powerpc/mm/numa.c+2 -1471 reply
5/18powerpc/numa: make vphn_enabled, prrn_enabled flags constarch/powerpc/mm/numa.c+2 -21 reply
6/18powerpc/numa: remove unreachable topology timer codearch/powerpc/mm/numa.c+0 -211 reply
7/18powerpc/numa: remove unreachable topology workqueue codearch/powerpc/mm/numa.c+0 -141 reply
8/18powerpc/numa: remove vphn_enabled and prrn_enabled internal flagsarch/powerpc/mm/numa.c+2 -41 reply
9/18powerpc/numa: stub out numa_update_cpu_topology()arch/powerpc/mm/numa.c+1 -1921 reply
10/18powerpc/numa: remove timed_topology_update()arch/powerpc/include/asm/topology.h arch/powerpc/mm/numa.c arch/powerpc/platforms/pseries/hotplug-cpu.c+0 -161 reply
11/18powerpc/numa: remove start/stop_topology_update()arch/powerpc/include/asm/topology.h arch/powerpc/mm/numa.c arch/powerpc/platforms/pseries/mobility.c +1 more+1 -381 reply
12/18powerpc/rtasd: simplify handle_rtas_event(), emit message on eventsarch/powerpc/kernel/rtasd.c+3 -251 reply
13/18powerpc/numa: remove prrn_is_enabled()arch/powerpc/include/asm/topology.h arch/powerpc/mm/numa.c+0 -101 reply
14/18powerpc/numa: remove arch_update_cpu_topologyarch/powerpc/include/asm/topology.h arch/powerpc/mm/numa.c+0 -161 reply
15/18powerpc/pseries: remove prrn special case from DT update patharch/powerpc/platforms/pseries/mobility.c+0 -270 replies
16/18powerpc/pseries: remove memory "re-add" implementationarch/powerpc/include/asm/rtas.h arch/powerpc/platforms/pseries/hotplug-memory.c+0 -430 replies
17/18powerpc/pseries: remove dlpar_cpu_readd()arch/powerpc/include/asm/topology.h arch/powerpc/platforms/pseries/hotplug-cpu.c+0 -200 replies
18/18powerpc/pseries: remove obsolete memory hotplug DT notifier codearch/powerpc/platforms/pseries/hotplug-memory.c+1 -640 replies

Reviews trailers per patch

13 of 18 patches have a Reviewed-by or Acked-by.

PatchGautham R. ShenoySrikar Dronamraju
1/18R-b
2/18
3/18R-b
4/18R-b
5/18R-b
6/18R-b
7/18R-b
8/18R-b
9/18R-b
10/18R-b
11/18R-b
12/18R-b
13/18R-b
14/18R-b
15/18
16/18
17/18
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/18] remove extended cede offline mode and bogus topology update code

Two major parts to this series:

1. Removal of the extended cede offline mode for CPUs as well as the partition suspend code which accommodates it by temporarily onlining all CPUs prior to suspending the LPAR. This solves some accounting problems, simplifies the pseries CPU hotplug code, and greatly uncomplicates the existing partition suspend code, easing a much-needed transition to the Linux suspend framework. The two patches which make up this part have been posted before:

https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=180718

and they are simply incorporated unchanged into the larger series here, with Gautham's Reviewed-by added to patch #1.

2. Removal of the long-disabled "topology update" code, most of which resides in mm/numa.c, but there are pieces in pseries and rtasd to excise as well. This code was an attempt to honor changes in a partition's NUMA properties arising from resource reassignments which occur as part of a migration, VPHN change, or a Dynamic Platform Optimizer operation. Its main technique is to remove and re-add affected processors and LMBs and hope in vain that the changes in cpu-node and physaddr-node relationships aren't disruptive. We want to provide user space with some indication that Linux's logical NUMA representation has become out of sync with the platform's assignments, but we need to get this unusable stuff out of the way before this code can sustain new features.

Nathan Lynch (18):
powerpc/pseries: remove cede offline state for CPUs powerpc/rtas: don't online CPUs for partition suspend powerpc/numa: remove ability to enable topology updates powerpc/numa: remove unreachable topology update code powerpc/numa: make vphn_enabled, prrn_enabled flags const powerpc/numa: remove unreachable topology timer code powerpc/numa: remove unreachable topology workqueue code powerpc/numa: remove vphn_enabled and prrn_enabled internal flags powerpc/numa: stub out numa_update_cpu_topology() powerpc/numa: remove timed_topology_update() powerpc/numa: remove start/stop_topology_update() powerpc/rtasd: simplify handle_rtas_event(), emit message on events powerpc/numa: remove prrn_is_enabled()
powerpc/numa: remove arch_update_cpu_topology powerpc/pseries: remove prrn special case from DT update path powerpc/pseries: remove memory "re-add" implementation powerpc/pseries: remove dlpar_cpu_readd() powerpc/pseries: remove obsolete memory hotplug DT notifier code

 Documentation/core-api/cpu_hotplug.rst        |   7 -
 arch/powerpc/include/asm/rtas.h               |   3 -
 arch/powerpc/include/asm/topology.h           |  27 -
 arch/powerpc/kernel/rtas.c                    | 122 +----
 arch/powerpc/kernel/rtasd.c                   |  28 +-
 arch/powerpc/mm/numa.c                        | 486 ------------------
 arch/powerpc/platforms/pseries/hotplug-cpu.c  | 189 +------
 .../platforms/pseries/hotplug-memory.c        | 107 +---
 arch/powerpc/platforms/pseries/mobility.c     |  31 --
 .../platforms/pseries/offline_states.h        |  38 --
 arch/powerpc/platforms/pseries/pmem.c         |   1 -
 arch/powerpc/platforms/pseries/smp.c          |  28 +-
 arch/powerpc/platforms/pseries/suspend.c      |  27 +-
 13 files changed, 22 insertions(+), 1072 deletions(-)
 delete mode 100644 arch/powerpc/platforms/pseries/offline_states.h
Signature · 1 line
2.25.4