Skip to content

Prep work for fanotify events with name info

Amir Goldstein linux-fsdevel oe-kbuild-all 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest20 patches 6 repliesIn review
  2. v120 patches 14 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20fsnotify: Rearrange fast path to minimise overhead when there is no watcherfs/notify/fsnotify.c include/linux/fsnotify.h include/linux/fsnotify_backend.h+27 -140 replies
2/20fsnotify: fold fsnotify() call into fsnotify_parent()fs/notify/fsnotify.c include/linux/fsnotify.h+31 -290 replies
3/20fsnotify: return non const from fsnotify_data_inode()fs/notify/fanotify/fanotify.c include/linux/fsnotify_backend.h+3 -40 replies
4/20nfsd: use fsnotify_data_inode() to get the unlinked inodefs/nfsd/filecache.c+3 -10 replies
5/20kernfs: do not call fsnotify() with name without a parentfs/kernfs/file.c+1 -10 replies
6/20inotify: do not use objectid when comparing eventsfs/notify/inotify/inotify_fsnotify.c+2 -20 replies
7/20fanotify: create overflow event typefs/notify/fanotify/fanotify.c fs/notify/fanotify/fanotify.h fs/notify/fanotify/fanotify_user.c+36 -270 replies
8/20fanotify: break up fanotify_alloc_event()fs/notify/fanotify/fanotify.c+85 -611 reply
9/20fsnotify: pass dir argument to handle_event() callbackfs/nfsd/filecache.c fs/notify/dnotify/dnotify.c fs/notify/fanotify/fanotify.c +8 more+64 -560 replies
10/20fanotify: generalize the handling of extra event flagsfs/notify/fanotify/fanotify.c+10 -50 replies
11/20fanotify: generalize merge logic of events on dirfs/notify/fanotify/fanotify.c+11 -110 replies
12/20fanotify: distinguish between fid encode error and null fidfs/notify/fanotify/fanotify.c+4 -100 replies
13/20fanotify: generalize test for FAN_REPORT_FIDfs/notify/fanotify/fanotify.c fs/notify/fanotify/fanotify_user.c include/linux/fanotify.h+16 -120 replies
14/20fanotify: mask out special event flags from ignored maskfs/notify/fanotify/fanotify_user.c+5 -00 replies
15/20fanotify: prepare for implicit event flags in mark maskfs/notify/fanotify/fanotify_user.c+24 -160 replies
16/20fanotify: use FAN_EVENT_ON_CHILD as implicit flag on sb/mount/non-dir marksfs/notify/fanotify/fanotify_user.c+10 -30 replies
17/20fanotify: remove event FAN_DIR_MODIFYfs/notify/fanotify/fanotify.c fs/notify/fsnotify.c include/linux/fsnotify.h +2 more+4 -180 replies
18/20fsnotify: add object type "child" to object type iteratorinclude/linux/fsnotify_backend.h+3 -00 replies
19/20fanotify: use struct fanotify_info to parcel the variable size bufferfs/notify/fanotify/fanotify.c fs/notify/fanotify/fanotify.h fs/notify/fanotify/fanotify_user.c+139 -430 replies
20/20fanotify: no external fh buffer in fanotify_name_eventfs/notify/fanotify/fanotify.c fs/notify/fanotify/fanotify.h+57 -235 replies

Reviews trailers per patch

1 of 20 patches has a Reviewed-by or Acked-by.

PatchTejun HeoGreg Kroah-Hartman
1/20
2/20
3/20
4/20
5/20A-b A-b
6/20
7/20
8/20
9/20
10/20
11/20
12/20
13/20
14/20
15/20
16/20
17/20
18/20
19/20
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/20] Prep work for fanotify events with name info

Hi Jan,

Following patches address your review comments on v2 [1]. Branch is avalable at [2] and test branch of complete work of the moment is available at [3].

Thanks,
Amir.

Changes sinve v2:
- Re-parcel variable size buffer using struct fanotify_info
- Move space reservation of _inline_fh_buf to struct fanotify_fid_event
- Add Acks on kernfs patch

[1] https://lore.kernel.org/linux-fsdevel/[email protected]/
[2] https://github.com/amir73il/linux/commits/fanotify_prep-v3
[3] https://github.com/amir73il/linux/commits/fanotify_name_fid

Amir Goldstein (19):
fsnotify: fold fsnotify() call into fsnotify_parent()
fsnotify: return non const from fsnotify_data_inode()
nfsd: use fsnotify_data_inode() to get the unlinked inode
kernfs: do not call fsnotify() with name without a parent
inotify: do not use objectid when comparing events
fanotify: create overflow event type
fanotify: break up fanotify_alloc_event()
fsnotify: pass dir argument to handle_event() callback
fanotify: generalize the handling of extra event flags
fanotify: generalize merge logic of events on dir
fanotify: distinguish between fid encode error and null fid
fanotify: generalize test for FAN_REPORT_FID
fanotify: mask out special event flags from ignored mask
fanotify: prepare for implicit event flags in mark mask
fanotify: use FAN_EVENT_ON_CHILD as implicit flag on sb/mount/non-dir
marks
fanotify: remove event FAN_DIR_MODIFY
fsnotify: add object type "child" to object type iterator
fanotify: use struct fanotify_info to parcel the variable size buffer
fanotify: no external fh buffer in fanotify_name_event

Mel Gorman (1):
fsnotify: Rearrange fast path to minimise overhead when there is no
watcher

 fs/kernfs/file.c                     |   2 +-
 fs/nfsd/filecache.c                  |   8 +-
 fs/notify/dnotify/dnotify.c          |   8 +-
 fs/notify/fanotify/fanotify.c        | 354 ++++++++++++++++-----------
 fs/notify/fanotify/fanotify.h        | 110 +++++++--
 fs/notify/fanotify/fanotify_user.c   | 110 +++++----
 fs/notify/fsnotify.c                 |  82 ++++---
 fs/notify/inotify/inotify.h          |   6 +-
 fs/notify/inotify/inotify_fsnotify.c |  11 +-
 fs/notify/inotify/inotify_user.c     |   4 +-
 include/linux/fanotify.h             |   6 +-
 include/linux/fsnotify.h             |  43 ++--
 include/linux/fsnotify_backend.h     |  34 ++-
 include/uapi/linux/fanotify.h        |   1 -
 kernel/audit_fsnotify.c              |  10 +-
 kernel/audit_tree.c                  |   6 +-
 kernel/audit_watch.c                 |   6 +-
 17 files changed, 500 insertions(+), 301 deletions(-)
Signature · 1 line
2.17.1