Skip to content

cryptodev: add raw data-path APIs

Fan Zhang dpdk-dev 15 versions – Applied

Status from this message: Applied to dpdk-next-crypto

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v13 Latest4 patches 1 replyApplied
  2. v124 patches 0 repliesSuperseded
  3. v114 patches 5 repliesSuperseded
Earlier versions · 12
VersionPostedPatchesRepliesStatus
v104 patches14 repliesSuperseded
v94 patches20 repliesSuperseded
v84 patches1 replySuperseded
v74 patches3 repliesSuperseded
v64 patches0 repliesSuperseded
v54 patches0 repliesSuperseded
v44 patches6 repliesSuperseded
v3 posting 3/34 patches0 repliesSuperseded
v3 posting 2/33 patches0 repliesSuperseded
v3 posting 1/33 patches0 repliesSuperseded
v23 patches1 replySuperseded
v11 patch5 repliesSuperseded

Changes in v13 from the cover letter

- Fixed a typo.

Patches in v13 Applied

#Subject and filesSizeRepliesApplied
1/4cryptodev: change crypto symmetric vector structureapp/test/test_cryptodev.c doc/guides/prog_guide/cryptodev_lib.rst doc/guides/rel_notes/release_20_11.rst +6 more+79 -490 replies
2/4cryptodev: add raw crypto data-path APIsdoc/guides/cryptodevs/features/default.ini doc/guides/prog_guide/cryptodev_lib.rst doc/guides/rel_notes/release_20_11.rst +4 more+665 -30 replies
3/4crypto/qat: add raw crypto data-path API supportdoc/guides/cryptodevs/features/qat.ini doc/guides/rel_notes/release_20_11.rst drivers/crypto/qat/meson.build +3 more+983 -20 replies
4/4test/crypto: add unit-test for cryptodev raw API testapp/test/test_cryptodev.c app/test/test_cryptodev.h app/test/test_cryptodev_blockcipher.c+803 -540 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAdam DybkowskiAkhil Goyal
SeriesA-b
1/4
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v13 thread

Cover letter [dpdk-dev] [dpdk-dev v13 0/4] cryptodev: add raw data-path APIs

The Crypto Raw data-path APIs are a set of APIs designed to enable external libraries/applications to leverage the cryptographic processing provided by DPDK crypto PMDs through the cryptodev API but in a manner that is not dependent on native DPDK data structures (eg. rte_mbuf, rte_crypto_op, ... etc) in their data-path implementation.

The raw data-path APIs have the following advantages:
- External data structure friendly design. The new APIs uses the operation descriptor ``struct rte_crypto_sym_vec`` that supports raw data pointer and IOVA addresses as input. Moreover, the APIs does not require the user to allocate the descriptor from mempool, nor requiring mbufs to describe input data's virtual and IOVA addresses. All these features made the translation from user's own data structure into the descriptor easier and more efficient.
- Flexible enqueue and dequeue operation. The raw data-path APIs gives the user more control to the enqueue and dequeue operations, including the capability of precious enqueue/dequeue count, abandoning enqueue or dequeue at any time, and operation status translation and set on the fly.

v13:
- Fixed a typo.

v12:
- Fixed and updated documentation.
- Fixed typo.

v11:
- Rebased on top of latest master.
- API changed followed by the discussion results.
- Fixed a few grammar error thanks to Akhil.
- Reverted attach session API changes.
- Fixed QAT driver bugs.

v10:
- Changed rte_crypto_sym_vec structure to support both sync cpu_crypto and async raw data-path API.
- Changed documentation.
- Changed API names.
- Changed the way data-path context is initialized.
- Added new API to attach session or xform to existing context.
- Changed QAT PMD accordingly with new APIs.
- Changed unit test to use the device feature flag for the raw API tests.

v9:
- Changed return types of submit_done() and dequeue_done() APIs.
- Added release note update.

v8:
- Updated following by comments.
- Fixed a few bugs.
- Fixed ARM build error.
- Updated the unit test covering all tests.

v7:
- Fixed a few typos.
- Fixed length calculation bugs.

v6:
- Rebased on top of DPDK 20.08.
- Changed to service ctx and added single job submit/dequeue.

v5:
- Changed to use rte_crypto_sym_vec as input.
- Changed to use public APIs instead of use function pointer.

v4:
- Added missed patch.

v3:
- Instead of QAT only API, moved the API to cryptodev.
- Added cryptodev feature flags.

v2:
- Used a structure to simplify parameters.
- Added unit tests.
- Added documentation.

Fan Zhang (4):
cryptodev: change crypto symmetric vector structure
cryptodev: add raw crypto data-path APIs crypto/qat: add raw crypto data-path API support test/crypto: add unit-test for cryptodev raw API test

 app/test/test_cryptodev.c                     | 812 ++++++++++++++-
 app/test/test_cryptodev.h                     |  12 +
 app/test/test_cryptodev_blockcipher.c         |  58 +-
 doc/guides/cryptodevs/features/default.ini    |   1 +
 doc/guides/cryptodevs/features/qat.ini        |   1 +
 doc/guides/prog_guide/cryptodev_lib.rst       | 109 +-
 doc/guides/rel_notes/release_20_11.rst        |  14 +
 drivers/crypto/aesni_gcm/aesni_gcm_pmd.c      |  18 +-
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c    |   9 +-
 drivers/crypto/qat/meson.build                |   1 +
 drivers/crypto/qat/qat_sym.h                  |  11 +
 drivers/crypto/qat/qat_sym_hw_dp.c            | 959 ++++++++++++++++++
 drivers/crypto/qat/qat_sym_pmd.c              |   9 +-
 lib/librte_cryptodev/rte_crypto_sym.h         |  40 +-
 lib/librte_cryptodev/rte_cryptodev.c          |  80 ++
 lib/librte_cryptodev/rte_cryptodev.h          | 413 +++++++-
 lib/librte_cryptodev/rte_cryptodev_pmd.h      |  51 +-
 .../rte_cryptodev_version.map                 |  10 +
 lib/librte_ipsec/esp_inb.c                    |  12 +-
 lib/librte_ipsec/esp_outb.c                   |  12 +-
 lib/librte_ipsec/misc.h                       |   6 +-
 21 files changed, 2530 insertions(+), 108 deletions(-)
 create mode 100644 drivers/crypto/qat/qat_sym_hw_dp.c
Signature · 1 line
2.20.1