Skip to content

sched: TTWU, IPI, and assorted stuff

Peter Zijlstra lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 30 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6sched: Fix ttwu_queue_cond()kernel/sched/core.c+12 -15 replies
2/6sched: Verify some SMP assumptionskernel/sched/core.c kernel/smp.c+6 -40 replies
3/6sched: s/WF_ON_RQ/WQ_ON_CPU/kernel/sched/core.c kernel/sched/sched.h+3 -31 reply
4/6smp, irq_work: Continue smp_call_function*() and irq_work*() integrationinclude/linux/irq_work.h include/linux/sched.h include/linux/smp.h +3 more+86 -580 replies
5/6irq_work: Cleanupinclude/linux/irq_work.h include/linux/irqflags.h kernel/bpf/stackmap.c +5 more+39 -351 reply
6/6smp: Cleanup smp_call_function*()arch/mips/kernel/process.c arch/mips/kernel/smp.c arch/s390/pci/pci_irq.c +11 more+44 -937 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchPaul E. McKenneyFrederic WeisbeckerDaniel ThompsonPetr MladekMel Gorman
SeriesT-b
1/6T-b A-b
2/6
3/6A-b
4/6R-b
5/6Revieved-by
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 0/6] sched: TTWU, IPI, and assorted stuff

Hi,

So Paul reported rcutorture hitting a NULL dereference, and patch #1 fixes it.

Now, patch #1 is obviously correct, but I can't explain how exactly it leads to the observed NULL pointer dereference. The NULL pointer deref happens in find_matching_se()'s last while() loop when is_same_group() fails even though both parents are NULL.

The only explanation I have for that is that we just did an activate_task()
while: 'task_cpu(p) != cpu_of(rq)', because then 'p->se.cfs_rq' doesn't match. However, I can't see how the lack of #1 would lead to that. Never-the-less, patch #2 adds assertions to warn us of this case.

Patch #3 is a trivial rename that ought to eradicate some confusion.

The last 3 patches is what I ended up with for cleaning up the whole smp_call_function/irq_work/ttwu thing more.