sched: TTWU, IPI, and assorted stuff
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 30 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | sched: Fix ttwu_queue_cond()kernel/ | +12 | 5 replies | |
| 2/6 | sched: Verify some SMP assumptionskernel/ kernel/ | +6 | 0 replies | |
| 3/6 | sched: s/WF_ON_RQ/WQ_ON_CPU/kernel/ kernel/ | +3 | 1 reply | |
| 4/6 | smp, irq_work: Continue smp_call_function*() and irq_work*() integrationinclude/ include/ include/ +3 more | +86 | 0 replies | |
| 5/6 | irq_work: Cleanupinclude/ include/ kernel/ +5 more | +39 | 1 reply | |
| 6/6 | smp: Cleanup smp_call_function*()arch/ arch/ arch/ +11 more | +44 | 7 replies |
Reviews trailers per patch
4 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Paul E. McKenney | Frederic Weisbecker | Daniel Thompson | Petr Mladek | Mel Gorman |
|---|---|---|---|---|---|
| Series | T-b | ||||
| 1/6 | T-b | A-b | |||
| 2/6 | |||||
| 3/6 | A-b | ||||
| 4/6 | R-b | ||||
| 5/6 | Revieved-by | ||||
| 6/6 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH 0/6] sched: TTWU, IPI, and assorted stuff
Hi,
So Paul reported rcutorture hitting a NULL dereference, and patch #1 fixes it.
Now, patch #1 is obviously correct, but I can't explain how exactly it leads to the observed NULL pointer dereference. The NULL pointer deref happens in find_matching_se()'s last while() loop when is_same_group() fails even though both parents are NULL.
The only explanation I have for that is that we just did an activate_task()
while: 'task_cpu(p) != cpu_of(rq)', because then 'p->se.cfs_rq' doesn't match. However, I can't see how the lack of #1 would lead to that. Never-the-less, patch #2 adds assertions to warn us of this case.
Patch #3 is a trivial rename that ought to eradicate some confusion.
The last 3 patches is what I ended up with for cleaning up the whole smp_call_function/irq_work/ttwu thing more.