Skip to content

cpufreq: Specify the default governor on command line

Quentin Perret linux-pm linuxppc-dev lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 16 repliesIn review
  2. v12 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- added Viresh's ack to patch 01
- moved the assignment of 'default_governor' in patch 02 to the governor registration path instead of the driver registration (Viresh)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2cpufreq: Register governors at core_initcallarch/powerpc/platforms/cell/cpufreq_spudemand.c drivers/cpufreq/cpufreq_conservative.c drivers/cpufreq/cpufreq_ondemand.c +5 more+36 -1060 replies
2/2cpufreq: Specify default governor on command lineDocumentation/admin-guide/kernel-parameters.txt Documentation/admin-guide/pm/cpufreq.rst drivers/cpufreq/cpufreq.c+26 -813 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchViresh Kumar
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] cpufreq: Specify the default governor on command line

This series enables users of prebuilt kernels (e.g. distro kernels) to specify their CPUfreq governor of choice using the kernel command line, instead of having to wait for the system to fully boot to userspace to switch using the sysfs interface. This is helpful for 2 reasons:
1. users get to choose the governor that runs during the actual boot;
2. it simplifies the userspace boot procedure a bit (one less thing to worry about).

To enable this, the first patch moves all governor init calls to core_initcall, to make sure they are registered by the time the drivers probe. This should be relatively low impact as registering a governor is a simple procedure (it gets added to a llist), and all governors already load at core_initcall anyway when they're set as the default in Kconfig. This also allows to clean-up the governors' init/exit code, and reduces boilerplate.

The second patch introduces the new command line parameter, inspired by its cpuidle counterpart. More details can be found in the respective patch headers.

Changes in v2:
- added Viresh's ack to patch 01
- moved the assignment of 'default_governor' in patch 02 to the governor registration path instead of the driver registration (Viresh)

Thanks,
Quentin

Quentin Perret (2):
cpufreq: Register governors at core_initcall
cpufreq: Specify default governor on command line

 .../admin-guide/kernel-parameters.txt         |  5 ++++
 Documentation/admin-guide/pm/cpufreq.rst      |  6 ++---
 .../platforms/cell/cpufreq_spudemand.c        | 26 ++-----------------
 drivers/cpufreq/cpufreq.c                     | 23 ++++++++++++----
 drivers/cpufreq/cpufreq_conservative.c        | 22 ++++------------
 drivers/cpufreq/cpufreq_ondemand.c            | 24 +++++------------
 drivers/cpufreq/cpufreq_performance.c         | 14 ++--------
 drivers/cpufreq/cpufreq_powersave.c           | 18 +++----------
 drivers/cpufreq/cpufreq_userspace.c           | 18 +++----------
 include/linux/cpufreq.h                       | 14 ++++++++++
 kernel/sched/cpufreq_schedutil.c              |  6 +----
 11 files changed, 62 insertions(+), 114 deletions(-)
Signature · 1 line
2.27.0.111.gc72c7da667-goog