Skip to content

mm: Page fault accounting cleanups

Peter Xu linux-alpha linux-arch linux-arm-kernel linux-csky linux-hexagon linux-m68k linux-mips linux-mm linux-parisc linux-riscv linux-s390 linux-sh linux-snps-arc linux-um linuxppc-dev lkml oe-kbuild-all openrisc sparclinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest25 patches 34 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/25mm/um: Fix extra accounting for page fault retriesarch/um/kernel/trap.c+7 -60 replies
2/25mm: Introduce mm_fault_accounting()include/linux/mm.h mm/memory.c+20 -04 replies
3/25mm/alpha: Use mm_fault_accounting()arch/alpha/mm/fault.c+4 -50 replies
4/25mm/arc: Use mm_fault_accounting()arch/arc/mm/fault.c+3 -120 replies
5/25mm/arm: Use mm_fault_accounting()arch/arm/mm/fault.c+4 -170 replies
6/25mm/arm64: Use mm_fault_accounting()arch/arm64/mm/fault.c+2 -152 replies
7/25mm/csky: Use mm_fault_accounting()arch/csky/mm/fault.c+1 -1210 replies
8/25mm/hexagon: Use mm_fault_accounting()arch/hexagon/mm/vm_fault.c+3 -60 replies
9/25mm/ia64: Use mm_fault_accounting()arch/ia64/mm/fault.c+3 -50 replies
10/25mm/m68k: Use mm_fault_accounting()arch/m68k/mm/fault.c+3 -100 replies
11/25mm/microblaze: Use mm_fault_accounting()arch/microblaze/mm/fault.c+3 -50 replies
12/25mm/mips: Use mm_fault_accounting()arch/mips/mm/fault.c+3 -110 replies
13/25mm/nds32: Use mm_fault_accounting()arch/nds32/mm/fault.c+3 -161 reply
14/25mm/nios2: Use mm_fault_accounting()arch/nios2/mm/fault.c+3 -100 replies
15/25mm/openrisc: Use mm_fault_accounting()arch/openrisc/mm/fault.c+3 -51 reply
16/25mm/parisc: Use mm_fault_accounting()arch/parisc/mm/fault.c+3 -50 replies
17/25mm/powerpc: Use mm_fault_accounting()arch/powerpc/mm/fault.c+4 -90 replies
18/25mm/riscv: Use mm_fault_accounting()arch/riscv/mm/fault.c+3 -182 replies
19/25mm/s390: Use mm_fault_accounting()arch/s390/mm/fault.c+5 -166 replies
20/25mm/sh: Use mm_fault_accounting()arch/sh/mm/fault.c+3 -122 replies
21/25mm/sparc32: Use mm_fault_accounting()arch/sparc/mm/fault_32.c+3 -130 replies
22/25mm/sparc64: Use mm_fault_accounting()arch/sparc/mm/fault_64.c+4 -120 replies
23/25mm/unicore32: Use mm_fault_accounting()arch/unicore32/mm/fault.c+7 -80 replies
24/25mm/x86: Use mm_fault_accounting()arch/x86/mm/fault.c+1 -90 replies
25/25mm/xtensa: Use mm_fault_accounting()arch/xtensa/mm/fault.c+3 -111 reply

Reviews trailers per patch

3 of 25 patches have a Reviewed-by or Acked-by.

PatchMax FilippovStafford HorneGreentime Hu
1/25
2/25
3/25
4/25
5/25
6/25
7/25
8/25
9/25
10/25
11/25
12/25
13/25A-b
14/25
15/25A-b
16/25
17/25
18/25
19/25
20/25
21/25
22/25
23/25
24/25
25/25A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/25] mm: Page fault accounting cleanups

Gerald Schaefer reported an issue a week ago regarding to incorrect page fault accountings for retried page fault after commit 4064b9827063 ("mm: allow VM_FAULT_RETRY for multiple times"):

https://lore.kernel.org/lkml/20200610174811.44b94525@thinkpad/

When I was looking at the issue, I actually found some other trivial issues too related to the page fault accounting, namely:

- Incorrect accountings

- The major issue that was reported by Gerald, that we did multiple accounting when the page fault retried while we should only do it once (for either perf event accounting or per-task accounting).

- In many archs, major fault is only accounted when the 1st page fault is a major fault, or the last page fault is a major fault. Ideally we should account the page fault as a major fault as long as any of the page fault retries is a major fault and keep the same behavior across archs.

- Missing accountings of perf events (PERF_COUNT_SW_PAGE_FAULTS[_[MAJ|MIN]]).

- Doing accounting with mmap_sem: not a big deal, but logically we can move it after releasing the mmap_sem because accounting does not need it.

This series tries to address all of them by introducing mm_fault_accounting() first, so that we move all the page fault accounting into the common code base, then call it properly from arch pf handlers just like handle_mm_fault(). There are some special cases, e.g., the um arch does not have "regs" in the fault handler, so it's still using the manual statistics.

For each of the patch that fixes a specific arch, I'm CCing the maintainers and the arch list if there is. Besides, I only lightly tested this series on x86.

Please have a look, thanks.

Peter Xu (25):
mm/um: Fix extra accounting for page fault retries
mm: Introduce mm_fault_accounting() mm/alpha: Use mm_fault_accounting() mm/arc: Use mm_fault_accounting()
mm/arm: Use mm_fault_accounting() mm/arm64: Use mm_fault_accounting() mm/csky: Use mm_fault_accounting() mm/hexagon: Use mm_fault_accounting() mm/ia64: Use mm_fault_accounting() mm/m68k: Use mm_fault_accounting() mm/microblaze: Use mm_fault_accounting() mm/mips: Use mm_fault_accounting() mm/nds32: Use mm_fault_accounting() mm/nios2: Use mm_fault_accounting() mm/openrisc: Use mm_fault_accounting() mm/parisc: Use mm_fault_accounting() mm/powerpc: Use mm_fault_accounting() mm/riscv: Use mm_fault_accounting() mm/s390: Use mm_fault_accounting()
mm/sh: Use mm_fault_accounting() mm/sparc32: Use mm_fault_accounting() mm/sparc64: Use mm_fault_accounting() mm/unicore32: Use mm_fault_accounting() mm/x86: Use mm_fault_accounting() mm/xtensa: Use mm_fault_accounting()

 arch/alpha/mm/fault.c      |  9 ++++-----
 arch/arc/mm/fault.c        | 15 +++------------
 arch/arm/mm/fault.c        | 21 ++++-----------------
 arch/arm64/mm/fault.c      | 17 ++---------------
 arch/csky/mm/fault.c       | 13 +------------
 arch/hexagon/mm/vm_fault.c |  9 +++------
 arch/ia64/mm/fault.c       |  8 +++-----
 arch/m68k/mm/fault.c       | 13 +++----------
 arch/microblaze/mm/fault.c |  8 +++-----
 arch/mips/mm/fault.c       | 14 +++-----------
 arch/nds32/mm/fault.c      | 19 +++----------------
 arch/nios2/mm/fault.c      | 13 +++----------
 arch/openrisc/mm/fault.c   |  8 +++-----
 arch/parisc/mm/fault.c     |  8 +++-----
 arch/powerpc/mm/fault.c    | 13 ++++---------
 arch/riscv/mm/fault.c      | 21 +++------------------
 arch/s390/mm/fault.c       | 21 +++++----------------
 arch/sh/mm/fault.c         | 15 +++------------
 arch/sparc/mm/fault_32.c   | 16 +++-------------
 arch/sparc/mm/fault_64.c   | 16 ++++------------
 arch/um/kernel/trap.c      | 13 +++++++------
 arch/unicore32/mm/fault.c  | 15 +++++++--------
 arch/x86/mm/fault.c        | 10 +---------
 arch/xtensa/mm/fault.c     | 14 +++-----------
 include/linux/mm.h         |  2 ++
 mm/memory.c                | 18 ++++++++++++++++++
 26 files changed, 101 insertions(+), 248 deletions(-)
Signature · 1 line
2.26.2