Skip to content

btrfs: workaround exhausted anonymous block device pool

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 22 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4btrfs: disk-io: don't allocate anonymous block device for user invisible rootsfs/btrfs/disk-io.c+11 -31 reply
2/4btrfs: detect uninitialized btrfs_root::anon_dev for user visible subvolumesfs/btrfs/inode.c+8 -17 replies
3/4btrfs: preallocate anon_dev for subvolume and snapshot creationfs/btrfs/disk-io.c fs/btrfs/disk-io.h fs/btrfs/ioctl.c +2 more+70 -910 replies
4/4btrfs: free anon_dev earlier to prevent exhausting anonymous block device poolfs/btrfs/inode.c+2 -03 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchJosef Bacik
1/4R-b
2/4
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] btrfs: workaround exhausted anonymous block device pool

There is a user report about transaction abort with a rare error number, -EMFILE:

  ------------[ cut here ]------------
  BTRFS: Transaction aborted (error -24)
  WARNING: CPU: 17 PID: 17041 at fs/btrfs/transaction.c:1576 create_pending_snapshot+0xbc4/0xd10 [btrfs]
  RIP: 0010:create_pending_snapshot+0xbc4/0xd10 [btrfs]
  Call Trace:
   create_pending_snapshots+0x82/0xa0 [btrfs]
   btrfs_commit_transaction+0x275/0x8c0 [btrfs]
   btrfs_mksubvol+0x4b9/0x500 [btrfs]
   btrfs_ioctl_snap_create_transid+0x174/0x180 [btrfs]
   btrfs_ioctl_snap_create_v2+0x11c/0x180 [btrfs]
   btrfs_ioctl+0x11a4/0x2da0 [btrfs]
   do_vfs_ioctl+0xa9/0x640
   ksys_ioctl+0x67/0x90
   __x64_sys_ioctl+0x1a/0x20
   do_syscall_64+0x5a/0x110
   entry_SYSCALL_64_after_hwframe+0x44/0xa9
  ---[ end trace 33f2f83f3d5250e9 ]---
  BTRFS: error (device sda1) in create_pending_snapshot:1576: errno=-24 unknown
  BTRFS info (device sda1): forced readonly
  BTRFS warning (device sda1): Skipping commit of aborted transaction.
  BTRFS: error (device sda1) in cleanup_transaction:1831: errno=-24 unknown

It turns out that, it's caused by exhausted anonymous block device pool. For that case, we don't have any good way to enlarge that pool to match btrfs subvolume limits.

But still we can improve the situation not to abort transaction, but report error gracefully to user.

This patchset will:
- Reduce the user of anonymous block device pool
Although it can only reduce the user by data reloc tree and orphan roots, it should still save save several ids.

- Catch the unintialized btrfs_root::anon_dev for user visible roots Just an extra safe net for previous patch

- Preallocate anon_dev for snapshot/subvolume creation
So user will get a graceful error other than transaction abort This patch should be the core of the patchset, as the remaining part won't have much user visible effect.

- Free anon_dev earlier to reduce the lifespan of anon_dev

Qu Wenruo (4):
btrfs: disk-io: don't allocate anonymous block device for user
invisible roots
btrfs: detect uninitialized btrfs_root::anon_dev for user visible
subvolumes
btrfs: preallocate anon_dev for subvolume and snapshot creation
btrfs: free anon_dev earlier to prevent exhausting anonymous block
device pool

 fs/btrfs/disk-io.c     | 59 +++++++++++++++++++++++++++++++++++++-----
 fs/btrfs/disk-io.h     |  2 ++
 fs/btrfs/inode.c       | 11 +++++++-
 fs/btrfs/ioctl.c       | 21 ++++++++++++++-
 fs/btrfs/transaction.c |  3 ++-
 fs/btrfs/transaction.h |  2 ++
 6 files changed, 88 insertions(+), 10 deletions(-)
Signature · 1 line
2.27.0