Skip to content

Patch Round-up for stable 4.2.1, freeze on 2020-06-22

Michael Roth qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest78 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/78block/nbd: extract the common cleanup codeblock/nbd.c+15 -110 replies
2/78block/nbd: fix memory leak in nbd_open()block/nbd.c+1 -00 replies
3/78i386: Resolve CPU models to v1 by defaultqemu-deprecated.texi target/i386/cpu.c+15 -10 replies
4/78qapi: better document NVMe blockdev @device parameterqapi/block-core.json+5 -10 replies
5/78target/arm: ensure we use current exception state after SCR updatetarget/arm/cpu.h target/arm/helper.c target/arm/helper.h +1 more+25 -40 replies
6/78block: Activate recursively even for already active nodesblock.c+24 -260 replies
7/78virtio-blk: fix out-of-bounds access to bitmap in notify_guest_bhhw/block/dataplane/virtio-blk.c+1 -10 replies
8/78numa: remove not needed checkhw/core/numa.c+1 -60 replies
9/78numa: properly check if numa is supportedhw/arm/sbsa-ref.c hw/core/machine.c+2 -30 replies
10/78backup-top: Begin drain earlierblock/backup-top.c+2 -20 replies
11/78arm/arm-powerctl: set NSACR.{CP11, CP10} bits in arm_set_cpu_on()target/arm/arm-powerctl.c+3 -00 replies
12/78arm/arm-powerctl: rebuild hflags after setting CP15 bits in arm_set_cpu_on()target/arm/arm-powerctl.c+3 -00 replies
13/78hw/i386/pc: fix regression in parsing vga cmdline parameterhw/i386/x86.c+4 -40 replies
14/78tests/ide-test: Create a single unit-test covering more PRDT casestests/ide-test.c+74 -1000 replies
15/78ide: Fix incorrect handling of some PRDTs in ide_dma_cb()hw/ide/core.c+22 -80 replies
16/78target/arm: Set ISSIs16Bit in make_issinfotarget/arm/translate.c+3 -00 replies
17/78virtio: update queue size on guest writehw/virtio/virtio-pci.c+2 -00 replies
18/78virtio-mmio: update queue size on guest writehw/virtio/virtio-mmio.c+2 -10 replies
19/78virtio: add ability to delete vq through a pointerhw/virtio/virtio.c include/hw/virtio/virtio.h+12 -50 replies
20/78virtio: make virtio_delete_queue idempotenthw/virtio/virtio.c+1 -00 replies
21/78virtio: reset region cache when on queue deletionhw/virtio/virtio.c+1 -00 replies
22/78virtio-net: delete also control queue when TX/RX deletedhw/net/virtio-net.c+2 -10 replies
23/78intel_iommu: a fix to vtd_find_as_from_bus_num()hw/i386/intel_iommu.c+1 -00 replies
24/78intel_iommu: add present bit check for pasid table entrieshw/i386/intel_iommu.c hw/i386/intel_iommu_internal.h+74 -190 replies
25/78vfio/pci: Don't remove irqchip notifier if not registeredhw/vfio/pci.c+3 -10 replies
26/78qcow2-bitmaps: fix qcow2_can_store_new_dirty_bitmapblock/qcow2-bitmap.c+18 -230 replies
27/78dp8393x: Mask EOL bit from descriptor addresseshw/net/dp8393x.c+11 -60 replies
28/78dp8393x: Always use 32-bit accesseshw/net/dp8393x.c+29 -180 replies
29/78dp8393x: Clean up endianness hackshw/net/dp8393x.c+6 -110 replies
30/78dp8393x: Have dp8393x_receive() return the packet sizehw/net/dp8393x.c+5 -40 replies
31/78dp8393x: Update LLFA and CRDA registers from rx descriptorhw/net/dp8393x.c+7 -40 replies
32/78dp8393x: Clear RRRA command register bit only when appropriatehw/net/dp8393x.c+3 -40 replies
33/78dp8393x: Implement packet size limit and RBAE interrupthw/net/dp8393x.c+9 -00 replies
34/78dp8393x: Don't clobber packet checksumhw/net/dp8393x.c+1 -00 replies
35/78dp8393x: Use long-word-aligned RRA pointers in 32-bit modehw/net/dp8393x.c+6 -20 replies
36/78dp8393x: Pad frames to word or long word boundaryhw/net/dp8393x.c+28 -110 replies
37/78dp8393x: Clear descriptor in_use field to release packethw/net/dp8393x.c+10 -00 replies
38/78dp8393x: Always update RRA pointers and sequence numbershw/net/dp8393x.c+7 -50 replies
39/78dp8393x: Don't reset Silicon Revision registerhw/net/dp8393x.c+1 -10 replies
40/78dp8393x: Don't stop reception upon RBE interrupt assertionhw/net/dp8393x.c+22 -130 replies
41/78s390/sclp: improve special wait psw logictarget/s390x/helper.c+1 -10 replies
42/78plugins/core: add missing break in cb_to_tcg_flagsplugins/core.c+1 -00 replies
43/78tcg: save vaddr temp for plugin usagetcg/tcg-op.c+20 -30 replies
44/78qcow2: update_refcount(): Reset old_table_index after qcow2_cache_put()block/qcow2-refcount.c+1 -00 replies
45/78qcow2: Fix qcow2_alloc_cluster_abort() for external data fileblock/qcow2-cluster.c+5 -20 replies
46/78iotests: Test copy offloading with external data filetests/qemu-iotests/244 tests/qemu-iotests/244.out+20 -00 replies
47/78qcow2: Fix alloc_cluster_abort() for pre-existing clustersblock/qcow2-cluster.c+1 -10 replies
48/78iotests/026: Test EIO on preallocated zero clustertests/qemu-iotests/026 tests/qemu-iotests/026.out tests/qemu-iotests/026.out.nocache+41 -00 replies
49/78iotests/026: Test EIO on allocation in a data-filetests/qemu-iotests/026 tests/qemu-iotests/026.out tests/qemu-iotests/026.out.nocache+44 -00 replies
50/78virtio: gracefully handle invalid region cacheshw/virtio/virtio.c+91 -80 replies
51/78scsi/qemu-pr-helper: Fix out-of-bounds access to trnptid_list[]scsi/qemu-pr-helper.c+10 -70 replies
52/78block/qcow2-threads: fix qcow2_decompressblock/qcow2-threads.c+7 -50 replies
53/78job: refactor progress to separate objectblockjob.c include/qemu/job.h include/qemu/progress_meter.h +3 more+76 -250 replies
54/78block/block-copy: fix progress calculationblock/backup.c block/block-copy.c include/block/block-copy.h+19 -250 replies
55/78target/ppc: Fix rlwinm on ppc64target/ppc/translate.c+11 -90 replies
56/78block/io: fix bdrv_co_do_copy_on_readvblock/io.c+1 -10 replies
57/78compat: disable edid on correct virtio-gpu devicehw/core/machine.c+1 -10 replies
58/78qga: Installer: Wait for installation to finishqga/installer/qemu-ga.wxs+1 -10 replies
59/78qga-win: Handle VSS_E_PROVIDER_ALREADY_REGISTERED errorqga/vss-win32/install.cpp+11 -00 replies
60/78qga-win: prevent crash when executing guest-file-read with large countqga/commands-win32.c+7 -10 replies
61/78qga: Fix undefined C behaviorqga/commands.c+7 -20 replies
62/78qemu-ga: document vsock-listen in the man pagedocs/interop/qemu-ga.rst qga/main.c+6 -30 replies
63/78hw/i386/amd_iommu.c: Fix corruption of log events passed to guesthw/i386/amd_iommu.c+1 -10 replies
64/78tcg/i386: Fix INDEX_op_dup2_vectcg/i386/tcg-target.inc.c+7 -30 replies
65/78dump: Fix writing of ELF sectiondump/dump.c+1 -10 replies
66/78xen-block: Fix double qlist remove and request leakhw/block/dataplane/xen-block.c+16 -320 replies
67/78vhost-user-gpu: Release memory returned by vu_queue_pop() with free()contrib/vhost-user-gpu/main.c contrib/vhost-user-gpu/virgl.c+3 -30 replies
68/78target/ppc: Fix mtmsr(d) L=1 variant that loses interruptstarget/ppc/translate.c+27 -190 replies
69/78hostmem: don't use mbind() if host-nodes is emptybackends/hostmem.c+4 -20 replies
70/78target/arm: Clear tail in gvec_fmul_idx_*, gvec_fmla_idx_*target/arm/vec_helper.c+2 -00 replies
71/78qemu-nbd: Close inherited stderrqemu-nbd.c+5 -10 replies
72/789p: Lock directory streams with a CoMutexhw/9pfs/9p.h+4 -45 replies
73/78net: Do not include a newline in the id of -nic devicesnet/net.c+1 -10 replies
74/78nbd/server: Avoid long error message assertions CVE-2020-10761nbd/server.c tests/qemu-iotests/143 tests/qemu-iotests/143.out+26 -30 replies
75/78virtio-balloon: fix free page hinting without an iothreadhw/virtio/virtio-balloon.c+16 -170 replies
76/78virtio-balloon: fix free page hinting check on unrealizehw/virtio/virtio-balloon.c+1 -10 replies
77/78virtio-balloon: unref the iothread when unrealizinghw/virtio/virtio-balloon.c+1 -00 replies
78/78block: Call attention to truncation of long NBD exportsblock.c block/nbd.c+18 -100 replies

Reviews trailers per patch

51 of 78 patches have a Reviewed-by or Acked-by.

PatchPeter MaydellRichard HendersonVladimir Sementsov-OgievskiyEric BlakeKevin WolfMichael S. TsirkinDavid HildenbrandLaurent VivierPeter XuEduardo HabkostDavid GibsonGreg KurzPhilippe Mathieu-DaudéMax ReitzStefano GarzarellaAlberto GarciaJán TomkoJanosch FrankAndrey ShinkevichStefan HajnocziEmilio G. CotaAlexander DuyckJohn SnowXie YongjiChai WenLukáš DoktorMarc-André LureauPaul DurrantNathan ChancellorCédric Le GoaterChristian Schoenebeck
1/78R-b R-b
2/78R-b R-b
3/78
4/78R-b R-b
5/78R-b T-b
6/78R-b
7/78R-b R-b
8/78
9/78
10/78
11/78R-b
12/78R-b
13/78
14/78
15/78R-b
16/78R-b
17/78
18/78R-b
19/78R-b R-b
20/78
21/78R-b
22/78R-b
23/78R-b R-b
24/78R-b R-b R-b
25/78Debugged-by R-b R-b
26/78R-b
27/78T-b
28/78T-b
29/78T-b R-b
30/78T-b R-b
31/78T-b R-b
32/78T-b R-b
33/78T-b
34/78T-b R-b
35/78T-b R-b
36/78T-b R-b
37/78T-b
38/78T-b
39/78
40/78T-b
41/78R-b A-b
42/78R-b R-b
43/78R-b R-b
44/78
45/78
46/78
47/78
48/78
49/78
50/78R-b
51/78
52/78R-b R-b
53/78R-b R-b
54/78R-b
55/78R-b
56/78R-b
57/78R-b T-b
58/78R-b
59/78
60/78
61/78
62/78R-b R-b
63/78R-b
64/78
65/78R-b R-b
66/78R-b
67/78R-b
68/78T-b R-b T-b
69/78T-b
70/78R-b
71/78R-b
72/78R-b
73/78R-b
74/78R-b
75/78R-b R-b R-b
76/78R-b R-b R-b
77/78R-b R-b R-b
78/78R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 31 reviewers.

Read the v1 thread

Cover letter [PATCH 00/78] Patch Round-up for stable 4.2.1, freeze on 2020-06-22

Hi everyone,

The following new patches are queued for QEMU stable v4.2.1:

https://github.com/mdroth/qemu/commits/stable-4.2-staging

The release is planned for 2020-06-25:

https://wiki.qemu.org/Planning/4.2

Due to delays on my part this release is going out beyond the normal ~4 month support window. v5.0.1 is scheduled to be released as normal.

Please respond here or CC [email protected] on any additional patches you think should be included in the release.

Thanks!

----------------------------------------------------------------
Alex Bennée (2):
target/arm: ensure we use current exception state after SCR update
tcg: save vaddr temp for plugin usage

Alexander Popov (2):
tests/ide-test: Create a single unit-test covering more PRDT cases
ide: Fix incorrect handling of some PRDTs in ide_dma_cb()

Anthony PERARD (1):
xen-block: Fix double qlist remove and request leak

Basil Salman (2):
qga: Installer: Wait for installation to finish
qga-win: prevent crash when executing guest-file-read with large count

Christian Borntraeger (1):
s390/sclp: improve special wait psw logic

Christophe de Dinechin (1):

      scsi/qemu-pr-helper: Fix out-of-bounds access to trnptid_list[]

Cornelia Huck (1):
compat: disable edid on correct virtio-gpu device

Daniel P. Berrangé (1):
qapi: better document NVMe blockdev @device parameter

David Hildenbrand (3):
virtio-balloon: fix free page hinting without an iothread
virtio-balloon: fix free page hinting check on unrealize
virtio-balloon: unref the iothread when unrealizing

Denis Plotnikov (1):
virtio-mmio: update queue size on guest write

Eduardo Habkost (1):
i386: Resolve CPU models to v1 by default

Emilio G. Cota (1):
plugins/core: add missing break in cb_to_tcg_flags

Eric Blake (3):
qga: Fix undefined C behavior
nbd/server: Avoid long error message assertions CVE-2020-10761
block: Call attention to truncation of long NBD exports

Finn Thain (14):
dp8393x: Mask EOL bit from descriptor addresses
dp8393x: Always use 32-bit accesses
dp8393x: Clean up endianness hacks
dp8393x: Have dp8393x_receive() return the packet size
dp8393x: Update LLFA and CRDA registers from rx descriptor
dp8393x: Clear RRRA command register bit only when appropriate
dp8393x: Implement packet size limit and RBAE interrupt
dp8393x: Don't clobber packet checksum
dp8393x: Use long-word-aligned RRA pointers in 32-bit mode
dp8393x: Pad frames to word or long word boundary
dp8393x: Clear descriptor in_use field to release packet
dp8393x: Always update RRA pointers and sequence numbers
dp8393x: Don't reset Silicon Revision register
dp8393x: Don't stop reception upon RBE interrupt assertion

Greg Kurz (1):
9p: Lock directory streams with a CoMutex

Igor Mammedov (3):
numa: remove not needed check
numa: properly check if numa is supported
hostmem: don't use mbind() if host-nodes is empty

Kevin Wolf (4):
block: Activate recursively even for already active nodes
qcow2: update_refcount(): Reset old_table_index after qcow2_cache_put()
qcow2: Fix qcow2_alloc_cluster_abort() for external data file
iotests: Test copy offloading with external data file

Li Hangjing (1):
virtio-blk: fix out-of-bounds access to bitmap in notify_guest_bh

Liu Yi L (2):
intel_iommu: a fix to vtd_find_as_from_bus_num()
intel_iommu: add present bit check for pasid table entries

Max Reitz (4):
backup-top: Begin drain earlier
qcow2: Fix alloc_cluster_abort() for pre-existing clusters iotests/026: Test EIO on preallocated zero cluster iotests/026: Test EIO on allocation in a data-file

Michael S. Tsirkin (3):
virtio: update queue size on guest write
virtio: add ability to delete vq through a pointer
virtio: make virtio_delete_queue idempotent

Nicholas Piggin (1):
target/ppc: Fix mtmsr(d) L=1 variant that loses interrupts

Niek Linnenbank (2):
arm/arm-powerctl: set NSACR.{CP11, CP10} bits in arm_set_cpu_on() arm/arm-powerctl: rebuild hflags after setting CP15 bits in arm_set_cpu_on()

Pan Nengyuan (2):
block/nbd: extract the common cleanup code
block/nbd: fix memory leak in nbd_open()

Peter Maydell (2):
hw/i386/amd_iommu.c: Fix corruption of log events passed to guest
dump: Fix writing of ELF section

Peter Wu (1):
hw/i386/pc: fix regression in parsing vga cmdline parameter

Peter Xu (1):
vfio/pci: Don't remove irqchip notifier if not registered

Philippe Mathieu-Daudé (1):
vhost-user-gpu: Release memory returned by vu_queue_pop() with free()

Raphael Pour (1):
qemu-nbd: Close inherited stderr

Richard Henderson (3):
target/arm: Set ISSIs16Bit in make_issinfo tcg/i386: Fix INDEX_op_dup2_vec
target/arm: Clear tail in gvec_fmul_idx_*, gvec_fmla_idx_*

Sameeh Jubran (1):
qga-win: Handle VSS_E_PROVIDER_ALREADY_REGISTERED error

Stefan Hajnoczi (2):
virtio: gracefully handle invalid region caches
qemu-ga: document vsock-listen in the man page

Thomas Huth (1):
net: Do not include a newline in the id of -nic devices

Vitaly Chikunov (1):
target/ppc: Fix rlwinm on ppc64

Vladimir Sementsov-Ogievskiy (5):
qcow2-bitmaps: fix qcow2_can_store_new_dirty_bitmap block/qcow2-threads: fix qcow2_decompress
job: refactor progress to separate object block/block-copy: fix progress calculation block/io: fix bdrv_co_do_copy_on_readv

Yuri Benditovich (2):
virtio: reset region cache when on queue deletion
virtio-net: delete also control queue when TX/RX deleted

 backends/hostmem.c                 |   6 +-
 block.c                            |  57 +++++------
 block/backup-top.c                 |   4 +-
 block/backup.c                     |  13 +--
 block/block-copy.c                 |  16 ++-
 block/io.c                         |   2 +-
 block/nbd.c                        |  48 +++++----
 block/qcow2-bitmap.c               |  41 ++++----
 block/qcow2-cluster.c              |   7 +-
 block/qcow2-refcount.c             |   1 +
 block/qcow2-threads.c              |  12 ++-
 blockjob.c                         |  16 +--
 contrib/vhost-user-gpu/main.c      |   4 +-
 contrib/vhost-user-gpu/virgl.c     |   2 +-
 docs/interop/qemu-ga.rst           |   5 +-
 dump/dump.c                        |   2 +-
 hw/9pfs/9p.h                       |   8 +-
 hw/arm/sbsa-ref.c                  |   1 -
 hw/block/dataplane/virtio-blk.c    |   2 +-
 hw/block/dataplane/xen-block.c     |  48 +++------
 hw/core/machine.c                  |   6 +-
 hw/core/numa.c                     |   7 +-
 hw/i386/amd_iommu.c                |   2 +-
 hw/i386/intel_iommu.c              |  93 +++++++++++++----
 hw/i386/intel_iommu_internal.h     |   1 +
 hw/i386/x86.c                      |   8 +-
 hw/ide/core.c                      |  30 ++++--
 hw/net/dp8393x.c                   | 200 ++++++++++++++++++++++++-------------
 hw/net/virtio-net.c                |   3 +-
 hw/vfio/pci.c                      |   4 +-
 hw/virtio/virtio-balloon.c         |  36 +++----
 hw/virtio/virtio-mmio.c            |   3 +-
 hw/virtio/virtio-pci.c             |   2 +
 hw/virtio/virtio.c                 | 116 ++++++++++++++++++---
 include/block/block-copy.h         |  15 +--
 include/hw/virtio/virtio.h         |   2 +
 include/qemu/job.h                 |  11 +-
 include/qemu/progress_meter.h      |  58 +++++++++++
 job-qmp.c                          |   4 +-
 job.c                              |   6 +-
 nbd/server.c                       |  23 ++++-
 net/net.c                          |   2 +-
 plugins/core.c                     |   1 +
 qapi/block-core.json               |   6 +-
 qemu-deprecated.texi               |   8 ++
 qemu-img.c                         |   6 +-
 qemu-nbd.c                         |   6 +-
 qga/commands-win32.c               |   8 +-
 qga/commands.c                     |   9 +-
 qga/installer/qemu-ga.wxs          |   2 +-
 qga/main.c                         |   4 +-
 qga/vss-win32/install.cpp          |  11 ++
 scsi/qemu-pr-helper.c              |  17 ++--
 target/arm/arm-powerctl.c          |   6 ++
 target/arm/cpu.h                   |   8 +-
 target/arm/helper.c                |  14 ++-
 target/arm/helper.h                |   1 +
 target/arm/translate.c             |   9 +-
 target/arm/vec_helper.c            |   2 +
 target/i386/cpu.c                  |   8 +-
 target/ppc/translate.c             |  66 ++++++------
 target/s390x/helper.c              |   2 +-
 tcg/i386/tcg-target.inc.c          |  10 +-
 tcg/tcg-op.c                       |  23 ++++-
 tests/ide-test.c                   | 174 ++++++++++++++------------------
 tests/qemu-iotests/026             |  53 ++++++++++
 tests/qemu-iotests/026.out         |  16 +++
 tests/qemu-iotests/026.out.nocache |  16 +++
 tests/qemu-iotests/143             |   4 +
 tests/qemu-iotests/143.out         |   2 +
 tests/qemu-iotests/244             |  14 +++
 tests/qemu-iotests/244.out         |   6 ++
 72 files changed, 963 insertions(+), 476 deletions(-)
 create mode 100644 include/qemu/progress_meter.h