Skip to content

Reapply DSA fix for dpaa-eth with proper Fixes: tag

Vladimir Oltean lkml netdev 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 6 repliesSuperseded

Changes in v2 from the cover letter

Corrected the reversed sysfs paths in the new commit description.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Revert "dpaa_eth: fix usage as DSA master, try 3"drivers/net/ethernet/freescale/dpaa/dpaa_eth.c+1 -10 replies
2/2dpaa_eth: fix usage as DSA master, try 4drivers/net/ethernet/freescale/dpaa/dpaa_eth.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 net 0/2] Reapply DSA fix for dpaa-eth with proper Fixes: tag

From: Vladimir Oltean <[email protected]>

Joakim notified me that this fix breaks stable trees. It turns out that my assessment about who-broke-who was wrong. The real Fixes: tag should have been:

Fixes 060ad66f9795 ("dpaa_eth: change DMA device")

which changes the device on which SET_NETDEV_DEV is made.

git describe --tags 060ad66f97954
v5.4-rc3-783-g060ad66f9795

Which means that it shouldn't have been backported to 4.19 and below. This series reverts the commit with the misleading commit message, and reapplies it with a corrected one. The resulting code is exactly the same, but now, the revert should make it to the stable trees (along with the bad fix), and the new fix should only make it down to v5.4.y.

Changes in v2:
Corrected the reversed sysfs paths in the new commit description.

Vladimir Oltean (2):
Revert "dpaa_eth: fix usage as DSA master, try 3"
dpaa_eth: fix usage as DSA master, try 4

Signature · 1 line
2.25.1