Skip to content

pinctrl: single: support #pinctrl-cells = 2

Drew Fustini linux-arm-kernel linux-devicetree linux-gpio linux-omap lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 12 repliesIn review
  2. v33 patches 2 repliesSuperseded
  3. v23 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches3 repliesSuperseded

change log from the cover letter

- v4: squash patches 2 and 3 together so that git biesct will not result in a boot failure

- v3: change order of patches to make sure the pinctrl-single.c patch does not break anything without the dts patches

- v2: remove outer parentheses from AM33XX_PADCONF macro as it causes a compile error in dtc. I had added it per suggestion from checkpatch about having parentheses around complex values.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2pinctrl: single: parse #pinctrl-cells = 2drivers/pinctrl/pinctrl-single.c+9 -23 replies
2/2ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2arch/arm/boot/dts/am33xx-l4.dtsi include/dt-bindings/pinctrl/omap.h+2 -24 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTony LindgrenHaojian Zhuang
SeriesA-b A-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] pinctrl: single: support #pinctrl-cells = 2

Currently, pinctrl-single only allows #pinctrl-cells = 1.

This series will allow pinctrl-single to also support #pinctrl-cells = 2

If "pinctrl-single,pins" has 3 arguments (offset, conf, mux) then pcs_parse_one_pinctrl_entry() does an OR operation on conf and mux to get the value to store in the register.

To take advantage of #pinctrl-cells = 2, the AM33XX_PADCONF macro in omap.h is modified to keep pin conf and pin mux values separate.

change log:
- v4: squash patches 2 and 3 together so that git biesct will not result in a boot failure

- v3: change order of patches to make sure the pinctrl-single.c patch does not break anything without the dts patches

- v2: remove outer parentheses from AM33XX_PADCONF macro as it causes a compile error in dtc. I had added it per suggestion from checkpatch about having parentheses around complex values.

Drew Fustini (2):
pinctrl: single: parse #pinctrl-cells = 2
ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2

 arch/arm/boot/dts/am33xx-l4.dtsi   |  2 +-
 drivers/pinctrl/pinctrl-single.c   | 11 +++++++++--
 include/dt-bindings/pinctrl/omap.h |  2 +-
 3 files changed, 11 insertions(+), 4 deletions(-)
Signature · 1 line
2.25.1