Skip to content

improve runtime loading of shared drivers

Bruce Richardson dpdk-dev 3 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyApplied
  2. v24 patches 4 repliesSuperseded
  3. v14 patches 0 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4eal: remove unnecessary null-termination in plugin pathlib/librte_eal/common/eal_common_options.c+1 -20 replies
2/4eal: load only shared libs from driver plugin directorieslib/librte_eal/common/eal_common_options.c+6 -00 replies
3/4eal: forbid loading drivers from insecure pathslib/librte_eal/common/eal_common_options.c+77 -80 replies
4/4eal: cache last directory permissions checkedlib/librte_eal/common/eal_common_options.c+8 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [dpdk-dev] [PATCH v3 0/4] improve runtime loading of shared drivers

This set includes a number of small improvements for handling the loading of drivers at runtime using the EAL -d flag.

It limits the loading of files to only those files which end in .so, which means that one can pass in the whole "drivers/" subfolder from a meson build and not get an error when DPDK trys to load a .a file.

It also puts in some basic permission checking to ensure that no drivers are loaded from a world-writable location on the filesystem, which would be a potential security hole on a mis-configured system.

v3: adjusted commit titles based on Thomas' feedback
skip over any paths which are not relative/absolute - assume any found from system directories by linker must be secure.

v2: rebased to fix errors on apply
fixed one checkpatch issue.

Bruce Richardson (4):
eal: remove unnecessary null-termination in plugin path
eal: load only shared libs from driver plugin directories
eal: forbid loading drivers from insecure paths
eal: cache last directory permissions checked

 lib/librte_eal/common/eal_common_options.c | 100 ++++++++++++++++++---
 1 file changed, 90 insertions(+), 10 deletions(-)
Signature · 1 line
2.25.1