Skip to content

console: unify return codes from ->setup() hook

Andy Shevchenko linux-serial lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6mips: Return proper error code from console ->setup() hookarch/mips/fw/arc/arc_con.c+3 -13 replies
2/6serial: sunsab: Return proper error code from console ->setup() hookdrivers/tty/serial/sunsab.c+1 -11 reply
3/6serial: sunzilog: Return proper error code from console ->setup() hookdrivers/tty/serial/sunzilog.c+1 -11 reply
4/6tty: hvc: Return proper error code from console ->setup() hookdrivers/tty/hvc/hvsi.c+1 -10 replies
5/6console: Propagate error code from console ->setup()kernel/printk/printk.c+3 -31 reply
6/6console: Fix trivia typo 'change' -> 'chance'kernel/printk/printk.c+1 -11 reply

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDavid S. MillerBenjamin HerrenschmidtPetr MladekThomas Bogendoerfer
SeriesR-b
1/6A-b
2/6A-b
3/6A-b
4/6
5/6A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH v1 0/6] console: unify return codes from ->setup() hook

Some of the console providers treat error code, returned by ->setup() hook, differently. Here is the unification of the behaviour.

The drivers checked by one of the below criteria:
1/ the driver has explicit struct console .setup assignment 2/ the driver has assigned callback to the setup member

All such drivers were read in order to see if there is any problematic return codes, and fixed accordingly which is this series in the result.

Andy Shevchenko (6):
mips: Return proper error code from console ->setup() hook
serial: sunsab: Return proper error code from console ->setup() hook
serial: sunzilog: Return proper error code from console ->setup() hook
tty: hvc: Return proper error code from console ->setup() hook
console: Propagate error code from console ->setup()
console: Fix trivia typo 'change' -> 'chance'

 arch/mips/fw/arc/arc_con.c    | 4 +++-
 drivers/tty/hvc/hvsi.c        | 2 +-
 drivers/tty/serial/sunsab.c   | 2 +-
 drivers/tty/serial/sunzilog.c | 2 +-
 kernel/printk/printk.c        | 8 ++++----
 5 files changed, 10 insertions(+), 8 deletions(-)
Signature · 1 line
2.27.0