Skip to content

ALSA: compress: Document stream states and fix gapless SM

Vinod Koul alsa-devel lkml 5 versions – Applied

Status from this message: Applied to for-next branch now. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 5 repliesApplied
  2. v43 patches 4 repliesSuperseded
  3. v33 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches4 repliesSuperseded
v13 patches8 repliesSuperseded

Changes in v5 from the cover letter

- Update SM diagram as suggested by Amadeusz

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/3ALSA: compress: document the compress audio state machineDocumentation/sound/designs/compress-offload.rst+51 -01 reply
2/3ALSA: compress: document the compress gapless audio state machineDocumentation/sound/designs/compress-offload.rst+32 -01 reply
3/3ALSA: compress: fix partial_drain completion stateinclude/sound/compress_driver.h sound/core/compress_offload.c+13 -13 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchSrinivas KandagatlaCharles Keepax
1/3R-b
2/3
3/3R-b T-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] ALSA: compress: Document stream states and fix gapless SM

Srini found issue with gapless implementation which prompted to look deeper into SM for compressed stream.

So documenting SM was first step, so first two patches add that. Last patch fixes the issue by keeping track on partial_drain and then moving state to 'running' in snd_compr_drain_notify() for partial_drain case on success. While at it, noticed snd_compr_drain_notify() is lockless state change, so fixed that as well.

I have tested this on Dragon board RB3, compressed audio works out of the box on that platform and Srini will send driver and fcplay patches for gapless soon.

Changes in v5:
- Update SM diagram as suggested by Amadeusz

Changes in v4:
- Add review tag by Charles
- fix the lock deadlock pointed by Charles

Changes in v3:
- Add pause->stop->free transition
- Add setup->free transition
- remove running->free as that goes thru stop

Changes in v2:
- Added tested tag by Srini
- Update compress SM with Free state and compr_stop() transitions

Vinod Koul (3):
ALSA: compress: document the compress audio state machine
ALSA: compress: document the compress gapless audio state machine
ALSA: compress: fix partial_drain completion state

 .../sound/designs/compress-offload.rst        | 83 +++++++++++++++++++
 include/sound/compress_driver.h               | 10 ++-
 sound/core/compress_offload.c                 |  4 +
 3 files changed, 96 insertions(+), 1 deletion(-)
Signature · 1 line
2.26.2