block: add block-dirty-bitmap-populate job
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 5 repliesIn review
- v36 patches 10 repliesSuperseded
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | block: add bitmap-populate jobMAINTAINERS block/ block/ +5 more | +286 | 1 reply | |
| 2/5 | blockdev: combine DriveBackupState and BlockdevBackupStateblockdev.c | +12 | 1 reply | |
| 3/5 | qmp: expose block-dirty-bitmap-populateblockdev.c qapi/ qapi/ | +94 | 0 replies | |
| 4/5 | iotests: move bitmap helpers into their own filetests/ tests/ | +132 | 1 reply | |
| 5/5 | iotests: add 298 for block-dirty-bitmap-populatetests/ tests/ tests/ | +4777 | 0 replies |
Reviews trailers per patch
1 of 5 patches has a Reviewed-by or Acked-by.
| Patch | Vladimir Sementsov-Ogievskiy |
|---|---|
| 1/5 | |
| 2/5 | |
| 3/5 | |
| 4/5 | R-b |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/5] block: add block-dirty-bitmap-populate job
This is NOT the final version of this patch series, but I'm posting it to revive conversation on the topic while fixing it to compile on top of meson changes.
v3 was: https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg06258.html
001/5:[0025] [FC] 'block: add bitmap-populate job'
002/5:[----] [--] 'blockdev: combine DriveBackupState and BlockdevBackupState' 003/5:[0004] [FC] 'qmp: expose block-dirty-bitmap-populate' 004/5:[----] [--] 'iotests: move bitmap helpers into their own file' 005/5:[----] [-C] 'iotests: add 298 for block-dirty-bitmap-populate'
I'm still trying to find the right QAPI contract (affects patch 1 and 3 for the qapi, and 5 for invoking the command in iotests), but right now, I'm leaning towards:
{ "execute": "block-dirty-bitmap-populate", "arguments": {
"job-id": "job0", "node": "target_node", "name": "target_bitmap",
"sources": [ { "pattern": "allocation", "node": "from_node" } ] } }which allows expansion into multiple sources, so that we can combine a populate action with a bitmap merge rather than having to do those as separate commands, like:
{ "execute": "block-dirty-bitmap-populate", "arguments": {
"job-id": "job0", "node": "target_node", "name": "target_bitmap",
"sources": [ { "pattern": "allocation", "node": "from_node" },
{ "pattern": "bitmap", "node": "from_node",
"bitmap": "from_bitmap" } ] } }John Snow (5):
block: add bitmap-populate job
blockdev: combine DriveBackupState and BlockdevBackupState
qmp: expose block-dirty-bitmap-populate
iotests: move bitmap helpers into their own file
iotests: add 298 for block-dirty-bitmap-populate
qapi/block-core.json | 66 + qapi/job.json | 6 +- qapi/transaction.json | 2 + include/block/block.h | 1 + include/block/block_int.h | 21 + block/bitmap-populate.c | 207 ++ blockdev.c | 104 +- blockjob.c | 3 +- MAINTAINERS | 1 + block/meson.build | 1 + tests/qemu-iotests/257 | 110 +- tests/qemu-iotests/298 | 232 ++ tests/qemu-iotests/298.out | 4544 +++++++++++++++++++++++++++++++++ tests/qemu-iotests/bitmaps.py | 131 + tests/qemu-iotests/group | 1 + 15 files changed, 5301 insertions(+), 129 deletions(-) create mode 100644 block/bitmap-populate.c create mode 100755 tests/qemu-iotests/298 create mode 100644 tests/qemu-iotests/298.out create mode 100644 tests/qemu-iotests/bitmaps.py
Signature · 1 line
2.28.0