Skip to content

Convert the IPMI watchdog to use the watchdog

[email protected] linux-watchdog 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10watchdog: Ignore stop_on_reboot if no stop functiondrivers/watchdog/watchdog_core.c+9 -31 reply
2/10watchdog: Add read capabilitydrivers/watchdog/watchdog_dev.c include/linux/watchdog.h+53 -00 replies
3/10watchdog: Add documentation for read capabilityDocumentation/watchdog/watchdog-kernel-api.rst+12 -01 reply
4/10watchdog: Add functions to set the timeout and pretimeoutdrivers/watchdog/watchdog_dev.c include/linux/watchdog.h+52 -61 reply
5/10watchdog: Export an interface to start the watchdogdrivers/watchdog/watchdog_dev.c include/linux/watchdog.h+29 -41 reply
6/10ipmi:watchdog: Convert over to the watchdog frameworkdrivers/char/ipmi/ipmi_watchdog.c+153 -2280 replies
7/10ipmi:watchdog: Allow the reboot timeout to be specifieddrivers/char/ipmi/ipmi_watchdog.c+8 -20 replies
8/10watchdog: Add a way to extend the timeout on a rebootdrivers/watchdog/watchdog_core.c include/linux/watchdog.h+6 -01 reply
9/10ipmi:watchdog: Convert over to watchdog framework reboot handlingdrivers/char/ipmi/ipmi_watchdog.c+3 -440 replies
10/10ipmi:watchdog: Add the op to get the current timeoutdrivers/char/ipmi/ipmi_watchdog.c+80 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] Convert the IPMI watchdog to use the watchdog

This has been discussed before, and I've been working on it. I think this is the minimum that can be done to keep the IPMI watchdog functionality exactly the same and use the watchdog subsystem.

The first patch is something that I thought might be a bug, and is not directly related to the changes.

The IPMI watchdog has the following capabilities that need extensions to the watchdog subsystem:

* The ability to provide read data on the device when a pretimeout occurs.
* The ability to dynamically set the timeout and pretimeout with module parameters.
* The ability to start the watchdog as soon as the driver starts.

I have no idea if anyone is using the capabilities, but they are there, unfortunately.

A patch later in the series adds the ability to modify the watchdog time on a reboot. This was specifically requested in the past, so I know it was at least used in the past. The IPMI watchdog driver can do this itself, but it's simple to add to the watchdog framework and gets rid of some redundant code.

This leaves the driver code in the ipmi directory. After these changes it could be moved, but it doesn't matter much to me.

Thanks,

-corey