Skip to content

cmdline: support Windows

Dmitry Kozlyuk dpdk-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 5 repliesIn review
  2. v27 patches 13 repliesSuperseded
  3. v17 patches 8 repliesSuperseded

Changes in v3 from the cover letter

* Add #ifdef workaround to keep API/ABI for Unices (Olivier).
* Fix missing cmdline_free() in test (Olivier).
* Rebase on ToT (Khoa).

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7cmdline: make implementation logically opaqueapp/test-cmdline/commands.c app/test/test_cmdline_lib.c doc/guides/rel_notes/deprecation.rst +5 more+60 -391 reply
2/7cmdline: add internal wrappers for terminal handlinglib/librte_cmdline/cmdline_os_unix.c lib/librte_cmdline/cmdline_private.h lib/librte_cmdline/cmdline_socket.c +2 more+52 -120 replies
3/7cmdline: add internal wrappers for character inputlib/librte_cmdline/cmdline.c lib/librte_cmdline/cmdline_os_unix.c lib/librte_cmdline/cmdline_private.h+30 -100 replies
4/7cmdline: add internal wrapper for vdprintflib/librte_cmdline/cmdline.c lib/librte_cmdline/cmdline_os_unix.c lib/librte_cmdline/cmdline_private.h+15 -10 replies
5/7eal/windows: improve compatibility networking headerslib/librte_eal/windows/include/arpa/inet.h lib/librte_eal/windows/include/netinet/in.h lib/librte_eal/windows/include/sys/socket.h+66 -00 replies
6/7cmdline: support Windowsconfig/meson.build lib/librte_cmdline/cmdline.c lib/librte_cmdline/cmdline_os_windows.c +6 more+250 -21 reply
7/7examples/cmdline: build on Windowsexamples/cmdline/commands.c examples/cmdline/main.c examples/meson.build+3 -51 reply

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRay KinsellaOlivier Matz
SeriesA-b
1/7A-b
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [dpdk-dev] [PATCH v3 0/7] cmdline: support Windows

This patchset enables librte_cmdline on Windows. To do that, it creates a number of wrappers for OS-dependent terminal handling and I/O. Considered alternative was to revive [1] and use libedit (Unix-only) for terminal handling. However, testing revealed that WinEditLine [2] is not a drop-in replacement for libedit, so this solution wouldn't be universal.

[1]: http://patchwork.dpdk.org/patch/38561
[2]: http://mingweditline.sourceforge.net

v3:
* Add #ifdef workaround to keep API/ABI for Unices (Olivier).
* Fix missing cmdline_free() in test (Olivier).
* Rebase on ToT (Khoa).

Dmitry Kozlyuk (7):
cmdline: make implementation logically opaque
cmdline: add internal wrappers for terminal handling
cmdline: add internal wrappers for character input
cmdline: add internal wrapper for vdprintf eal/windows: improve compatibility networking headers
cmdline: support Windows
examples/cmdline: build on Windows

 app/test-cmdline/commands.c                 |   8 +-
 app/test/test_cmdline_lib.c                 |  44 ++---
 config/meson.build                          |   2 +
 doc/guides/rel_notes/deprecation.rst        |   4 +
 examples/cmdline/commands.c                 |   1 -
 examples/cmdline/main.c                     |   1 -
 examples/meson.build                        |   6 +-
 lib/librte_cmdline/cmdline.c                |  30 +--
 lib/librte_cmdline/cmdline.h                |  18 +-
 lib/librte_cmdline/cmdline_os_unix.c        |  53 +++++
 lib/librte_cmdline/cmdline_os_windows.c     | 207 ++++++++++++++++++++
 lib/librte_cmdline/cmdline_parse.c          |   5 +-
 lib/librte_cmdline/cmdline_private.h        |  53 +++++
 lib/librte_cmdline/cmdline_socket.c         |  25 +--
 lib/librte_cmdline/cmdline_vt100.c          |   1 -
 lib/librte_cmdline/cmdline_vt100.h          |   4 +
 lib/librte_cmdline/meson.build              |   6 +
 lib/librte_cmdline/rte_cmdline_version.map  |   8 +
 lib/librte_eal/windows/include/arpa/inet.h  |  30 +++
 lib/librte_eal/windows/include/netinet/in.h |  12 ++
 lib/librte_eal/windows/include/sys/socket.h |  24 +++
 lib/meson.build                             |   1 +
 22 files changed, 475 insertions(+), 68 deletions(-)
 create mode 100644 lib/librte_cmdline/cmdline_os_unix.c
 create mode 100644 lib/librte_cmdline/cmdline_os_windows.c
 create mode 100644 lib/librte_cmdline/cmdline_private.h
 create mode 100644 lib/librte_eal/windows/include/arpa/inet.h
 create mode 100644 lib/librte_eal/windows/include/sys/socket.h
Signature · 1 line
2.28.0